[java] Fixing a spotbugs test, excluding a pattern for JUnit4TestBase

SeleniumHQ · Nov 19, 2020 · a028804 · a028804
1 parent da87645
commit a028804
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/java/server/test/org/openqa/testing/FakeHttpServletResponse.java b/java/server/test/org/openqa/testing/FakeHttpServletResponse.java
@@ -17,8 +17,10 @@
 
 package org.openqa.testing;
 
+import java.io.OutputStreamWriter;
 import java.io.PrintWriter;
 import java.io.StringWriter;
+import java.io.Writer;
 import java.util.Collection;
 import java.util.Locale;
 
@@ -35,7 +37,8 @@ public class FakeHttpServletResponse extends HeaderContainer
   private final StringWriter stringWriter = new StringWriter();
   private final ServletOutputStream servletOutputStream =
       new StringServletOutputStream(stringWriter);
-  private final PrintWriter printWriter = new PrintWriter(servletOutputStream, false);
+  private final Writer writer = new OutputStreamWriter(servletOutputStream, UTF_8);
+  private final PrintWriter printWriter = new PrintWriter(writer);
   private int status = HttpServletResponse.SC_OK;
 
   @Override

diff --git a/java/spotbugs-excludes.xml b/java/spotbugs-excludes.xml
@@ -179,6 +179,11 @@
     <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
   </Match>
 
+  <Match>
+    <Class name="org.openqa.selenium.testing.JUnit4TestBase"/>
+    <Bug pattern="URF_UNREAD_PUBLIC_OR_PROTECTED_FIELD"/>
+  </Match>
+
   <Match>
     <Class name="org.openqa.selenium.testing.StaticResources"/>
     <Bug pattern="NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE"/>