Move .NET CDP generation targets to list

SeleniumHQ · Dec 4, 2020 · 9492ee6 · 9492ee6
1 parent d2b483c
commit 9492ee6
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 21 deletions.
diff --git a/dotnet/defs.bzl b/dotnet/defs.bzl
@@ -4,6 +4,13 @@ load("//dotnet/private:generate_devtools.bzl", _generate_devtools = "generate_de
 load("//dotnet/private:merge_assemblies.bzl", _merged_assembly = "merged_assembly")
 load("//dotnet/private:nuget.bzl", _nuget_package = "nuget_package", _nuget_push = "nuget_push")
 load("//dotnet/private:nunit_test.bzl", _nunit_test = "nunit_test")
+load("//dotnet:selenium-dotnet-version.bzl", "SUPPORTED_DEVTOOLS_VERSIONS")
+
+def devtools_version_targets():
+    targets = []
+    for devtools_version in SUPPORTED_DEVTOOLS_VERSIONS:
+        targets.append("//dotnet/src/webdriver/cdp:generate-{}".format(devtools_version))
+    return targets
 
 generated_assembly_info = _generated_assembly_info
 csharp_executable = _csharp_executable

diff --git a/dotnet/src/webdriver/BUILD.bazel b/dotnet/src/webdriver/BUILD.bazel
@@ -5,7 +5,8 @@ load(
     "merged_assembly",
     "generated_assembly_info",
     "nuget_package",
-    "nuget_push")
+    "nuget_push",
+    "devtools_version_targets",)
 load(
     "//dotnet:selenium-dotnet-version.bzl",
     "ASSEMBLY_COMPANY",
@@ -16,6 +17,7 @@ load(
     "SE_VERSION",
     "SUPPORTED_NET_FRAMEWORKS",
     "SUPPORTED_NET_STANDARD_VERSIONS",
+    "SUPPORTED_DEVTOOLS_VERSIONS",
 )
 
 generated_assembly_info(
@@ -48,11 +50,7 @@ generated_assembly_info(
         "Support/*.cs",
     ]) + [
         ":assembly-info",
-        "//dotnet/src/webdriver/cdp:generate-v84",
-        "//dotnet/src/webdriver/cdp:generate-v85",
-        "//dotnet/src/webdriver/cdp:generate-v86",
-        "//dotnet/src/webdriver/cdp:generate-v87",
-    ],
+    ] + devtools_version_targets(),
     out = "WebDriver",
     resources = [
         "//javascript/atoms/fragments:find-elements.js",
@@ -97,11 +95,7 @@ generated_assembly_info(
         "Support/*.cs",
     ]) + [
         ":assembly-info",
-        "//dotnet/src/webdriver/cdp:generate-v84",
-        "//dotnet/src/webdriver/cdp:generate-v85",
-        "//dotnet/src/webdriver/cdp:generate-v86",
-        "//dotnet/src/webdriver/cdp:generate-v87",
-    ],
+    ] + devtools_version_targets(),
     out = "WebDriver",
     resources = [
         "//javascript/atoms/fragments:find-elements.js",
@@ -137,11 +131,7 @@ generated_assembly_info(
         "Support/*.cs",
     ]) + [
         ":assembly-info",
-        "//dotnet/src/webdriver/cdp:generate-v84",
-        "//dotnet/src/webdriver/cdp:generate-v85",
-        "//dotnet/src/webdriver/cdp:generate-v86",
-        "//dotnet/src/webdriver/cdp:generate-v87",
-    ],
+    ] + devtools_version_targets(),
     out = "strongnamed/WebDriver",
     keyfile = "//dotnet:WebDriver.snk",
     resources = [
@@ -187,11 +177,7 @@ generated_assembly_info(
         "Support/*.cs",
     ]) + [
         ":assembly-info",
-        "//dotnet/src/webdriver/cdp:generate-v84",
-        "//dotnet/src/webdriver/cdp:generate-v85",
-        "//dotnet/src/webdriver/cdp:generate-v86",
-        "//dotnet/src/webdriver/cdp:generate-v87",
-    ],
+    ] + devtools_version_targets(),
     out = "strongnamed/WebDriver",
     keyfile = "//dotnet:WebDriver.snk",
     resources = [