[rb] debug clients have fixed problem with non-nil open_timeout value…

…s, switch to using library default
SeleniumHQ · Mar 1, 2021 · 8e62549 · 8e62549
1 parent 2965e4e
commit 8e62549
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/rb/lib/selenium/webdriver/remote/http/default.rb b/rb/lib/selenium/webdriver/remote/http/default.rb
@@ -55,8 +55,7 @@ def http
                 http.verify_mode = OpenSSL::SSL::VERIFY_NONE
               end
 
-              # Defaulting open_timeout to nil to be consistent with Ruby 2.2 and earlier.
-              http.open_timeout = open_timeout
+              http.open_timeout = open_timeout if open_timeout
               http.read_timeout = read_timeout if read_timeout
 
               start(http)

diff --git a/rb/spec/unit/selenium/webdriver/remote/http/default_spec.rb b/rb/spec/unit/selenium/webdriver/remote/http/default_spec.rb
@@ -34,7 +34,7 @@ module Http
           it 'assigns default timeout to nil' do
             http = client.send :http
 
-            expect(http.open_timeout).to eq nil
+            expect(http.open_timeout).to eq 60
             expect(http.read_timeout).to eq 60
           end