Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update .event() for page and screen #45

Open
calvinfo opened this issue Jun 24, 2014 · 2 comments
Open

update .event() for page and screen #45

calvinfo opened this issue Jun 24, 2014 · 2 comments

Comments

@calvinfo
Copy link
Contributor

thinking for those two, it just makes sense to include the fullName automatically:

Page.prototype.event = function(name){
  if (!arguments.length) name = this.fullName();
  return name
    ? 'Viewed ' + name + ' Page'
    : 'Loaded a Page';
};

since I think in most places we are doing that anyway

@yields, thoughts?

@calvinfo
Copy link
Contributor Author

tippecanoe @ianstormtaylor too

@ianstormtaylor
Copy link
Contributor

sgtm!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants