Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ci #18

Merged
merged 37 commits into from
Feb 3, 2025
Merged

feat: ci #18

merged 37 commits into from
Feb 3, 2025

Conversation

greged93
Copy link
Collaborator

@greged93 greged93 commented Jan 31, 2025

  • Adds required CI checks to the repo.
  • Fixes lints, formatting, docs and imports issues.

Resolves #3

@greged93 greged93 requested a review from frisitano January 31, 2025 08:26
@@ -0,0 +1,6 @@
version: 2
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest recommendation for the Rust ecosystem is to add the Cargo.lock file to the version control, and either use dependabot or cargo update && cargo test in CI.
rust-lang/cargo#8728

Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! One proposal - should we include a Makefile that allows us to run the lints locally? This will allow us to assert compliance with CI before pushing and could speed up dev cycles.

- name: Run unit tests
run: cargo nextest run --workspace --locked -E '!kind(test)'

it:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe it would be preferable to be more verbose and name this integration.

@greged93
Copy link
Collaborator Author

Agree, on it!

Base automatically changed from feat/gossip-source to main January 31, 2025 13:54
Copy link
Collaborator

@frisitano frisitano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for this! LGTM

@frisitano frisitano merged commit af02841 into main Feb 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Design and Implement CI
2 participants