-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: ci #18
Conversation
@@ -0,0 +1,6 @@ | |||
version: 2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest recommendation for the Rust ecosystem is to add the Cargo.lock
file to the version control, and either use dependabot or cargo update && cargo test
in CI.
rust-lang/cargo#8728
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One proposal - should we include a Makefile
that allows us to run the lints locally? This will allow us to assert compliance with CI before pushing and could speed up dev cycles.
.github/workflows/test.yaml
Outdated
- name: Run unit tests | ||
run: cargo nextest run --workspace --locked -E '!kind(test)' | ||
|
||
it: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe it would be preferable to be more verbose and name this integration
.
Agree, on it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thanks for this! LGTM
Resolves #3