lib/sdt_alloc: properly unlock stack on allocation nerror

etsal · etsal · commit 2cb91f835953 · 2025-04-24T10:47:50.000-07:00
diff --git a/lib/sdt_alloc.bpf.c b/lib/sdt_alloc.bpf.c
@@ -925,6 +925,7 @@ int scx_stk_fill_new_elems(struct scx_stk *stack)
 	nr_pages = stack->nr_pages_per_alloc;
 	nelems = (nr_pages * PAGE_SIZE) / stack->data_size;
 	if (nelems > SCX_RING_MAX) {
+		arena_spin_unlock(stack->lock);
 		scx_bpf_error("new elements must fit into a single ring");
 		return -EINVAL;
 	}

Original file line number	Diff line number	Diff line change
`@@ -925,6 +925,7 @@ int scx_stk_fill_new_elems(struct scx_stk *stack)`
`925`	`925`	`nr_pages = stack->nr_pages_per_alloc;`
`926`	`926`	`nelems = (nr_pages * PAGE_SIZE) / stack->data_size;`
`927`	`927`	`if (nelems > SCX_RING_MAX) {`
	`928`	`+ arena_spin_unlock(stack->lock);`
`928`	`929`	`scx_bpf_error("new elements must fit into a single ring");`
`929`	`930`	`return -EINVAL;`
`930`	`931`	`}`