improvement: New inlay hints options #6236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkciesluk
force-pushed
the
inlay-hint-options
branch
3 times, most recently
from
c762f7b to
082c6bb
Compare
kasiaMarek
approved these changes
Mar 26, 2024
| @@ -231,7 +225,7 @@ object UserConfiguration { | |||
| |""".stripMargin, | |||
| ), | |||
| UserConfigurationOption( | |||
| "show-inferred-type", | |||
| "inferred-types", | |||
There was a problem hiding this comment.
Shouldn't this be inlay-hints.inferred-types?
There was a problem hiding this comment.
Right, I've missed that. Even inlay-hints.inferred-types.enable
| val qualStart = sel.qualifier.pos.start | ||
| val nameStart = sel.namePosition.start | ||
| qualStart != nameStart && nameStart < text.length() && | ||
| !text.slice(qualEnd, nameStart).contains(".") |
There was a problem hiding this comment.
Can you explain what are you fixing here?
There was a problem hiding this comment.
The were some false positives, but I don't remember where exactly
jkciesluk
force-pushed
the
inlay-hint-options
branch
from
082c6bb to
70af532
Compare
tgodzik
requested changes
Apr 4, 2024
mtags/src/main/scala-2/scala/meta/internal/pc/PcInlayHintsProvider.scala
Show resolved
Hide resolved
tests/unit/src/main/scala/tests/BaseInlayHintsExpectSuite.scala
Outdated
Show resolved
Hide resolved
Adds new user configuration for inlay hints, with a fallback to old settings. Also adds separate option for inlay hints inside pattern match.
jkciesluk
force-pushed
the
inlay-hint-options
branch
from
70af532 to
3428def
Compare
rochala
pushed a commit
to scala/scala3
that referenced
this pull request
May 6, 2024
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jul 6, 2024
Changes from: - scalameta/metals#6225 - scalameta/metals#6236 - scalameta/metals#6241 - scalameta/metals#6303 - scalameta/metals#6308 [Cherry-picked 1cdf99f]
WojciechMazur
pushed a commit
to scala/scala3
that referenced
this pull request
Jul 6, 2024
Changes from: - scalameta/metals#6225 - scalameta/metals#6236 - scalameta/metals#6241 - scalameta/metals#6303 - scalameta/metals#6308 [Cherry-picked 1cdf99f]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds new user configuration for inlay hints, with a fallback to old settings.
Also adds separate option for inlay hints inside pattern match.