bugfix: Document highlight on generic class init in scala 3 #5878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkciesluk
force-pushed
the
i5877
branch
2 times, most recently
from
6e7ebb5 to
c061153
Compare
kasiaMarek
reviewed
Nov 29, 2023
| case (id: Ident) :: (_: New) :: (sel: Select) :: _ | ||
| if id.symbol == NoSymbol && sel.symbol.isConstructor => | ||
| Some(symbolAlternatives(sel.symbol.owner), id.sourcePos) | ||
| case (sel @ Select(New(_: Ident), _)) :: (_: TypeApply) :: _ |
There was a problem hiding this comment.
What if there is a longer Select there, e.g. O.<<Ab@@c>>[Int](2)?
There was a problem hiding this comment.
Thanks for noticing, it should work now.
kasiaMarek
approved these changes
Dec 5, 2023
mtags/src/main/scala-3/scala/meta/internal/pc/PcCollector.scala
Outdated
Show resolved
Hide resolved
tgodzik
added a commit
to scala/scala3
that referenced
this pull request
Dec 6, 2023
jkciesluk
force-pushed
the
i5877
branch
2 times, most recently
from
ba7c64e to
a31706e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5877