[Scala 3] Incorrect named arguments completions

[tgodzik]

Describe the bug

"""|trait Foo {
| def bar[A](fst: A, snd: Int, thd: Int = 23)
|}
|object Main {
| def foo: Foo = ???
| foo.bar(123, @@)
|}
|""".stripMargin

Expected behavior

Completions should be for both params:

"""|snd = : Int
|thd = : Int
|""".stripMargin

Operating system

None

Editor/Extension

None

Version of Metals

v1.5.2

Extra context or search terms

https://github.com/scalameta/metals/pull/7182/files

[mbovel]

I reproduced on my Mac with Metals 1.5.1. After running the "Trigger Suggest" command, I see:

So I guess, this should also suggest "snd"?

[mbovel]

I get the same without the body of bar:

Build definition is coming from scala-cli.
Build server currently being used is scala-cli v1.5.0. ([Reset](command:metals.reset-choice?%5B%22Build+server+selection%22%5D))

[bishabosha]

I also investigated and can reproduce with Scala 3.3.4 and 3.5.2, but it seems to be fixed in Scala 3.3.5/3.6.3

[mbovel]

I was running with Scala 3.5.0.

With 3.6.3, I see snd = as expected:

[mbovel]

@tgodzik not sure what we should do here. Should we fix it for the case where the user run a version in 3.3.1..3.3.2? In later versions, this works as expected.

[bishabosha]

We probably wasted a bunch of time not realising that the plan is to continue supporting the older scala LTS versions in metals - and now looks like we can back port whatever was fixed in scala/scala3

[mbovel]

Guess: maybe this has been fixed by scala/scala3#18702 in the new presentation compiler.

So to support older version, should we backport the fix to https://github.com/scalameta/metals/blob/main/mtags/src/main/scala-3/scala/meta/internal/pc?

[mbovel]

For reference, here is how we ran the test:

$ sbt --client '++3.3.3! cross/testOnly tests.BaseCompletionSuite.CompletionArgSuite -- *default-args8*'

[tgodzik]

For future reference, we don't have to backport it to metals. It's fine to have it fixed in the newest presentation compiler only. Thanks for checking!

[tgodzik]

Also, sorry for not responding earlier 😓