SBT: refactor external library dependencies

Author: kitbellew

build.sbt

@@ -197,9 +197,16 @@ lazy val runtime = project
   )
   .dependsOn(interfaces)
 
-val excludePprint = ExclusionRule(organization = "com.lihaoyi")
-val excludeCollection =
-  ExclusionRule(organization = "org.scala-lang.modules", name = "scala-collection-compat_2.13")
+lazy val depScalameta = Def.settings(
+  libraryDependencies += {
+    val sm = ("org.scalameta" %% "scalameta" % V.scalameta).excludeAll("com.lihaoyi")
+    if (isScala3.value)
+      sm.excludeAll(
+        "org.scala-lang.modules" % s"scala-collection-compat_${scalaBinaryVersion.value}"
+      ).cross(CrossVersion.for3Use2_13)
+    else sm
+  }
+)
 
 lazy val parser = crossProject(JVMPlatform, NativePlatform, JSPlatform)
   .withoutSuffixFor(JVMPlatform)
@@ -220,19 +227,7 @@ lazy val cli = project
       "com.lihaoyi" %% "pprint" % V.pprint,
       "org.scalameta" %% "metaconfig-typesafe-config" % V.metaconfig
     ),
-    libraryDependencies ++= crossSetting(
-      scalaVersion.value,
-      if2 = List(
-        ("org.scalameta" %% "scalameta" % V.scalameta)
-          .excludeAll(excludePprint)
-      ),
-      if3 = List(
-        ("org.scalameta" %% "scalameta" % V.scalameta)
-          .excludeAll(excludePprint)
-          .excludeAll(excludeCollection)
-          .cross(CrossVersion.for3Use2_13)
-      )
-    )
+    depScalameta
   )
   .dependsOn(parser.jvm)
 
@@ -249,21 +244,13 @@ lazy val mdoc = project
       scalaVersion,
       scalaBinaryVersion
     ),
-    libraryDependencies ++= crossSetting(
-      scalaVersion.value,
-      if3 = List(
-        "org.scala-lang" %% "scala3-compiler" % scalaVersion.value,
-        ("org.scalameta" %% "scalameta" % V.scalameta)
-          .excludeAll(excludePprint)
-          .excludeAll(excludeCollection)
-          .cross(CrossVersion.for3Use2_13)
-      ),
-      if2 = List(
-        "org.scala-lang" % "scala-compiler" % scalaVersion.value,
-        ("org.scalameta" %% "scalameta" % V.scalameta)
-          .excludeAll(excludePprint)
-      )
-    ),
+    depScalameta,
+    libraryDependencies += {
+      if (isScala3.value)
+        "org.scala-lang" %% "scala3-compiler" % scalaVersion.value
+      else
+        "org.scala-lang" % "scala-compiler" % scalaVersion.value
+    },
     libraryDependencies ++= jsoniter,
     libraryDependencies ++= List(
       "com.googlecode.java-diff-utils" % "diffutils" % "1.3.0",
@@ -299,9 +286,7 @@ val tests = project
   .settings(
     sharedSettings,
     publish / skip := true,
-    libraryDependencies ++= List(
-      "org.scalameta" %% "munit" % V.munit
-    ),
+    depMunit,
     buildInfoPackage := "tests",
     buildInfoKeys := Seq[BuildInfoKey](
       scalaVersion,
@@ -318,9 +303,7 @@ val jsdocs = project
     scalaJSLinkerConfig ~= {
       _.withModuleKind(ModuleKind.CommonJSModule)
     },
-    libraryDependencies ++= List(
-      "org.scala-js" %%% "scalajs-dom" % scalajsDom
-    ),
+    depJsDom,
     scalaJSUseMainModuleInitializer := true,
     Compile / npmDependencies ++= List(
       "ms" -> "2.1.1"
@@ -337,9 +320,7 @@ val jswebsitedocs = project
     scalaJSLinkerConfig ~= {
       _.withModuleKind(ModuleKind.ESModule)
     },
-    libraryDependencies ++= List(
-      "org.scala-js" %%% "scalajs-dom" % scalajsDom
-    )
+    depJsDom
   )
   .enablePlugins(ScalaJSPlugin)
 
@@ -348,9 +329,7 @@ lazy val worksheets = project
   .settings(
     sharedSettings,
     publish / skip := true,
-    libraryDependencies ++= List(
-      "org.scalameta" %% "munit" % V.munit % Test
-    )
+    depMunit % Test
   )
   .dependsOn(mdoc, tests)
 
@@ -369,19 +348,11 @@ lazy val unit = project
         "io.github.cibotech" %% "evilplot" % "0.9.2"
       )
     ),
-    libraryDependencies ++= List(
-      "org.scalameta" %% "munit" % V.munit % Test
-    ),
-    libraryDependencies ++= crossSetting(
-      scalaVersion.value,
-      if3 = List(
-        ("co.fs2" %% "fs2-core" % V.fs2)
-          .cross(CrossVersion.for3Use2_13)
-      ),
-      if2 = List(
-        "co.fs2" %% "fs2-core" % V.fs2
-      )
-    ),
+    depMunit % Test,
+    libraryDependencies += {
+      val dep = "co.fs2" %% "fs2-core" % V.fs2
+      if (isScala3.value) dep.cross(CrossVersion.for3Use2_13) else dep
+    },
     buildInfoPackage := "tests.cli",
     buildInfoKeys := Seq[BuildInfoKey](
       "testsInputClassDirectory" -> (testsInput / Compile / classDirectory).value
@@ -396,9 +367,7 @@ lazy val unitJS = project
     sharedSettings,
     publish / skip := true,
     Compile / unmanagedSourceDirectories ++= multiScalaDirectories("tests/unit-js").value,
-    libraryDependencies ++= List(
-      "org.scalameta" %% "munit" % V.munit % Test
-    ),
+    depMunit % Test,
     buildInfoPackage := "tests.js",
     buildInfoKeys := Seq[BuildInfoKey](
       "testsInputClassDirectory" -> (testsInput / Compile / classDirectory).value
@@ -426,10 +395,10 @@ lazy val plugin = project
     pluginCrossBuild / sbtVersion := "1.1.6",
     crossScalaVersions := List(scala212),
     moduleName := "sbt-mdoc",
+    depMunit % Test,
     libraryDependencies ++= List(
       "org.jsoup" % "jsoup" % "1.12.1",
       "org.scalacheck" %% "scalacheck" % V.scalacheck % Test,
-      "org.scalameta" %% "munit" % V.munit % Test,
       "org.scalameta" %% "testkit" % V.scalameta % Test
     ),
     Compile / resourceGenerators += Def.task {
@@ -563,3 +532,11 @@ def localCrossPublishProject(ref: Project, scalaV: String): Def.Initialize[Task[
       )
     val _ = Project.extract(newState).runTask(ref / publishLocal, newState)
   }
+
+val depMunit = Def.settings(
+  libraryDependencies += "org.scalameta" %% "munit" % V.munit
+)
+
+val depJsDom = Def.settings(
+  libraryDependencies += "org.scala-js" %%% "scalajs-dom" % scalajsDom
+)