Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

append_simulations method return types for NLE and NRE classes is different from the return type of their parent method #1453

Open
abelaba opened this issue Mar 15, 2025 · 0 comments

Comments

@abelaba
Copy link
Contributor

abelaba commented Mar 15, 2025

The append_simulations methods for the NRE and NLE classes have a return type of RatioEstimator and LikelihoodEstimator respectively, but the parent method they inherit has a return type of NeuralInference.

Currently, there is a # type ignore on the method calls so pyright will not display an error. But if you remove those comments pyright will display an error that there is a return type mismatch.

) -> "RatioEstimator":

) -> "LikelihoodEstimator":

) -> "NeuralInference":

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant