Skip to content

Commit 62387c9

Browse files
clang-tidy for all targets
1 parent 431d7f9 commit 62387c9

File tree

5 files changed

+8
-7
lines changed

5 files changed

+8
-7
lines changed

CMakeLists.txt

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ project(cppparser)
66
set(CMAKE_CXX_STANDARD 17)
77
set(CMAKE_EXPORT_COMPILE_COMMANDS ON)
88
set(CMAKE_CXX_STANDARD_INCLUDE_DIRECTORIES ${CMAKE_CXX_IMPLICIT_INCLUDE_DIRECTORIES})
9-
# set(CMAKE_CXX_CLANG_TIDY clang-tidy --config-file=${CMAKE_CURRENT_SOURCE_DIR}/.clang-tidy)
9+
set(CLANG_TIDY_COMMAND "clang-tidy" "--config-file=${CMAKE_CURRENT_SOURCE_DIR}/.clang-tidy")
1010

1111
if(MSVC)
1212
SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} /wd\"4996\"")

cppast/CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -17,5 +17,6 @@ target_include_directories(cppast
1717
PUBLIC
1818
include
1919
)
20+
set_target_properties(cppast PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY_COMMAND}")
2021

2122
add_subdirectory(test)

cppparser/CMakeLists.txt

-1
Original file line numberDiff line numberDiff line change
@@ -86,5 +86,4 @@ target_link_libraries(cppparser
8686
cppparser_lex_and_yacc
8787
)
8888

89-
set(CLANG_TIDY_COMMAND "clang-tidy" "--config-file=${CMAKE_CURRENT_SOURCE_DIR}/../.clang-tidy")
9089
set_target_properties(cppparser PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY_COMMAND}")

cppwriter/CMakeLists.txt

+1
Original file line numberDiff line numberDiff line change
@@ -12,3 +12,4 @@ target_link_libraries(cppwriter
1212
PUBLIC
1313
cppast
1414
)
15+
set_target_properties(cppwriter PROPERTIES CXX_CLANG_TIDY "${CLANG_TIDY_COMMAND}")

cppwriter/src/cppwriter.cpp

+5-5
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ namespace cppcodegen {
99

1010
namespace {
1111

12-
static void emitAttribute(std::uint32_t attr, std::ostream& stm)
12+
static void EmitAttribute(std::uint32_t attr, std::ostream& stm)
1313
{
1414
if (attr & cppast::CppIdentifierAttrib::STATIC)
1515
stm << "static ";
@@ -28,7 +28,7 @@ static void emitAttribute(std::uint32_t attr, std::ostream& stm)
2828
stm << "mutable ";
2929
}
3030

31-
static void emitTypeModifier(const cppast::CppTypeModifier& modifier, std::ostream& stm)
31+
static void EmitTypeModifier(const cppast::CppTypeModifier& modifier, std::ostream& stm)
3232
{
3333
std::uint8_t constBit = 0;
3434
for (constBit = 0; constBit < modifier.ptrLevel_; ++constBit)
@@ -297,15 +297,15 @@ void CppWriter::emitUsingNamespace(const cppast::CppUsingNamespaceDecl& usingNsO
297297
void CppWriter::emitVarType(const cppast::CppVarType& varTypeObj, std::ostream& stm) const
298298
{
299299
const auto attr = varTypeObj.typeAttr() | (IsConst(varTypeObj) ? cppast::CppIdentifierAttrib::CONST : 0);
300-
emitAttribute(attr, stm);
300+
EmitAttribute(attr, stm);
301301
if (varTypeObj.compound())
302302
emit(*varTypeObj.compound(), stm, CppIndent(), true);
303303
else
304304
stm << varTypeObj.baseType();
305305
const auto& origTypeModifier = varTypeObj.typeModifier();
306306
const cppast::CppTypeModifier typeModifier {
307307
origTypeModifier.refType_, origTypeModifier.ptrLevel_, origTypeModifier.constBits_ & ~1};
308-
emitTypeModifier(typeModifier, stm);
308+
EmitTypeModifier(typeModifier, stm);
309309
if (varTypeObj.parameterPack())
310310
stm << "...";
311311
}
@@ -378,7 +378,7 @@ void CppWriter::emitVarList(const cppast::CppVarList& varListObj, std::ostream&
378378
{
379379
stm << ", ";
380380
const auto& decl = varDeclList[i];
381-
emitTypeModifier(decl, stm);
381+
EmitTypeModifier(decl, stm);
382382
emitVarDecl(stm, decl, false);
383383
}
384384

0 commit comments

Comments
 (0)