enable ‘globstar’

[davidchambers]

This configuration does not currently work as one might expect:

source-files = src/**/*.js

When the globstar shell option is not enabled, ** is not recursive; one must provide multiple patterns if the source files are not all siblings. In addition to being inelegant, src/*.js src/**/*.js is fragile as it hard-codes the maximum depth.

This pull request enables the globstar shell option before expanding source-files and readme-source-files. :)

The following script can be run once to demonstrate the existing behaviour and once to demonstrate the new behaviour:

#!/usr/bin/env bash
set -euf -o pipefail

cd "$(mktemp -d)"
pwd

tee package.json <<EOF
{
  "name": "repo-name",
  "version": "0.0.0",
  "devDependencies": {
    "sanctuary-scripts": "sanctuary-js/sanctuary-scripts#$1"
  },
  "scripts": {
    "doctest": "sanctuary-doctest",
    "lint": "sanctuary-lint",
    "release": "sanctuary-release",
    "test": "npm run lint && sanctuary-test && npm run doctest"
  }
}
EOF

tee .config <<EOF
repo-owner = repo-owner
repo-name = repo-name
source-files = foo/**/*.js
EOF

tee .eslintrc.json <<EOF
{
  "root": true,
  "extends": ["./node_modules/sanctuary-style/eslint-es6.json"]
}
EOF

touch CONTRIBUTING.md
touch LICENSE
touch .gitignore
touch .npmrc

mkdir -p foo/bar/baz
echo '"use strict"' >foo/index.js
echo '"use strict"' >foo/bar/index.js
echo '"use strict"' >foo/bar/baz/index.js

npm install
npm run lint

When run against master, only errors in foo/bar/index.js are reported. When run against davidchambers/globstar, errors in all three source files are reported.

[Avaq]

🙂👍