Update vulnerable packages and replace deprecated mocha.opts #41
Conversation
| "mocha": { | ||
| "ui": "tdd" |
There was a problem hiding this comment.
I think this has to be added as a command line argument, here:
Line 21 in 545d2fe
Otherwise I don't think it's going to be applied in dependent projects.
There was a problem hiding this comment.
Ah, I forgot about mocha.opts, sorry for the misdirection. See #41 (comment)
There was a problem hiding this comment.
I think I've come full circle. Your original code was correct (prior to bf9fb04). We just need to tell other users of the lib to use the same approach. Currently the README advertises using mocha.opts. What do you think @davidchambers ?
There was a problem hiding this comment.
I agree, Aldwin. I suggest the following:
Configurable via variables (
min-branch-coverage) and themochafield of package.json.
|
@wuweiss sorry for the conflicting feedback. It seems we need two things to be completed for this PR to be acceptable:
Commit, force push, and we should be good to go. Right, @davidchambers ? |
|
That sounds good to me, Aldwin. :) If you would like, @wuweiss, Aldwin or I could make these two small changes. I know what it's like to receive feedback on a pull request once my attention is elsewhere. |
|
Sorry I was AFC, will do the changes this evening. Thanks for your help. |
wuweiss
force-pushed
the
updated-vuln-dependencies
branch
from
bf9fb04 to
8b08107
Compare
davidchambers
force-pushed
the
updated-vuln-dependencies
branch
from
0adc87d to
49c8641
Compare
No description provided.