beautify testing for PrivateKey.Child

Author: sammymu

golden_addon.go

@@ -105,17 +105,6 @@ func main() {
 			path:     []uint32{0, 2147483647, 1, 2147483646, 2},
 			wantPriv: "xprvA48ALo8BDjcRET68R5RsPzF3H7WeyYYtHcyUeLRGBPHXu6CJSGjwW7dWoeUWTEzT7LG3qk6Eg6x2ZoqD8gtyEFZecpAyvchksfLyg3Zbqam",
 		},
-
-		/*
-			// Custom tests to trigger specific conditions.
-			{
-				// Seed 000000000000000000000000000000da.
-				name:     "Derived privkey with zero high byte m/0",
-				master:   "xprv9s21ZrQH143K4FR6rNeqEK4EBhRgLjWLWhA3pw8iqgAKk82ypz58PXbrzU19opYcxw8JDJQF4id55PwTsN1Zv8Xt6SKvbr2KNU5y8jN8djz",
-				path:     []uint32{0},
-				wantPriv: "xprv9uC5JqtViMmgcAMUxcsBCBFA7oYCNs4bozPbyvLfddjHou4rMiGEHipz94xNaPb1e4f18TRoPXfiXx4C3cDAcADqxCSRSSWLvMBRWPctSN9",
-			},
-		*/
 	}
 
 	seeds := map[string]string{
@@ -192,8 +181,18 @@ func main() {
 }
 
 func oneMore() *Goldie {
+	/*
+		// Custom tests to trigger specific conditions.
+		{
+			// Seed 000000000000000000000000000000da.
+			name:     "Derived privkey with zero high byte m/0",
+			master:   "xprv9s21ZrQH143K4FR6rNeqEK4EBhRgLjWLWhA3pw8iqgAKk82ypz58PXbrzU19opYcxw8JDJQF4id55PwTsN1Zv8Xt6SKvbr2KNU5y8jN8djz",
+			path:     []uint32{0},
+			wantPriv: "xprv9uC5JqtViMmgcAMUxcsBCBFA7oYCNs4bozPbyvLfddjHou4rMiGEHipz94xNaPb1e4f18TRoPXfiXx4C3cDAcADqxCSRSSWLvMBRWPctSN9",
+		},
+	*/
 	goldie := &Goldie{
-		Seed: " 000000000000000000000000000000da",
+		Seed: "000000000000000000000000000000da",
 		Chains: []ChainGoldie{
 			{
 				Path:               "m",

master_key.go

@@ -19,9 +19,6 @@ func GenerateMasterKey(rand io.Reader, keyID Magic,
 	}
 
 	seed := make([]byte, seedLen)
-	//if n, err := rand.Read(seed); nil != err || n != seedLen {
-	//	return nil, ErrNoEnoughEntropy
-	//}
 	if _, err := io.ReadFull(rand, seed); nil != err {
 		return nil, ErrNoEnoughEntropy
 	}

private_key_test.go

@@ -42,6 +42,7 @@ func TestPrivateKey_AddressPubKeyHash(t *testing.T) {
 	}
 }
 
+/*
 func TestPrivateKey_Child_OK(t *testing.T) {
 	// The private extended keys for test vectors in [BIP32].
 	testVec1MasterPrivKey := "xprv9s21ZrQH143K3QTDL4LXw2F7HEK3wJUD2nW2nRk4stbPy6cq3jPPqjiChkVvvNKmPGJxWUtg6LnF5kejMRNNU3TGtRBeJgk33yuGBxrMPHi"
@@ -171,10 +172,14 @@ tests:
 		}
 	}
 }
+*/
 
 func TestPrivateKey_Child_OK2(t *testing.T) {
-	var testCases []bip32.Goldie
+	var testCases, addOn []bip32.Goldie
 	bip32.ReadGoldenJSON(bip32.GoldenName, &testCases)
+	bip32.ReadGoldenJSON(bip32.GoldenAddOnName, &addOn)
+
+	testCases = append(testCases, addOn...)
 
 	for _, c := range testCases {
 		c := c

testdata/bip32_addon.golden

@@ -70,7 +70,7 @@
     ]
   },
   {
-    "Seed": " 000000000000000000000000000000da",
+    "Seed": "000000000000000000000000000000da",
     "Chains": [
       {
         "Path": "m",
@@ -85,3 +85,4 @@
     ]
   }
 ]
+

testing.go

@@ -15,6 +15,7 @@ import (
 
 const GoldenBase = "testdata"
 const GoldenName = "bip32.golden"
+const GoldenAddOnName = "bip32_addon.golden"
 
 var GoldenPath = filepath.Join(GoldenBase, GoldenName)