Refactoring

sammycage · sammycage · commit 1582c9c5aaf8 · 2024-08-23T04:54:42.000+01:00
diff --git a/include/lunasvg.h b/include/lunasvg.h
@@ -175,9 +175,9 @@ class LUNASVG_API Bitmap {
 
     /**
      * @brief clear
-     * @param color
+     * @param value
      */
-    void clear(uint32_t color);
+    void clear(uint32_t value);
 
     /**
      * @brief convertToRGBA
diff --git a/meson_options.txt b/meson_options.txt
@@ -1,3 +1,2 @@
 option('examples', type : 'feature', value : 'auto')
 option('tests', type : 'feature', value : 'auto')
-option('expat', type : 'feature', value : 'auto')
diff --git a/source/lunasvg.cpp b/source/lunasvg.cpp
@@ -118,9 +118,7 @@ bool Bitmap::writeToPng(const std::string& filename) const
 
 plutovg_surface_t* Bitmap::release()
 {
-    auto surface = m_surface;
-    m_surface = nullptr;
-    return surface;
+    return std::exchange(m_surface, nullptr);
 }
 
 Box::Box(float x, float y, float w, float h)
diff --git a/source/svgproperty.h b/source/svgproperty.h
@@ -4,7 +4,6 @@
 #include "graphics.h"
 
 #include <string>
-#include <vector>
 
 namespace lunasvg {
 

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,2 @@`
`1`	`1`	`option('examples', type : 'feature', value : 'auto')`
`2`	`2`	`option('tests', type : 'feature', value : 'auto')`
`3`		`-option('expat', type : 'feature', value : 'auto')`
Original file line number	Diff line number	Diff line change
`@@ -118,9 +118,7 @@ bool Bitmap::writeToPng(const std::string& filename) const`
`118`	`118`
`119`	`119`	`plutovg_surface_t* Bitmap::release()`
`120`	`120`	`{`
`121`		`- auto surface = m_surface;`
`122`		`- m_surface = nullptr;`
`123`		`- return surface;`
	`121`	`+ return std::exchange(m_surface, nullptr);`
`124`	`122`	`}`
`125`	`123`
`126`	`124`	`Box::Box(float x, float y, float w, float h)`