update MSRV to 1.80 and test it in CI #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carljm
requested review from
nikomatsakis,
MichaReiser,
davidbarsky and
Veykril
✅ Deploy Preview for salsa-rs canceled.
|
CodSpeed Performance ReportMerging #712 will not alter performanceComparing Summary
|
MichaReiser
approved these changes
Feb 22, 2025
Veykril
approved these changes
Feb 22, 2025
|
To add context as far as rust-analyzer is concerned regarding MSRV, our policy there is that we have no minimum. (we have a maximum of second latest released stable) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Looks like codspeed doesn't like merge groups CodSpeedHQ/action#126. Kicked it out from the required jobs for merging now |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We specified an MSRV of 1.76 in
Cargo.toml, but this was a lie, because it wasn't tested anywhere.This updates our MSRV to 1.80, the oldest Rust that current main branch actually compiles on, and adds a CI run on 1.80 so that it's tested.
This requires also updating the
rustversionmacro on thecompile_failtest so that it runs only on stable Rust later than 1.84; that test snapshots compiler output and fails on any Rust version earlier than 1.84.(Over in #603 I asked about upping our MSRV to 1.83, but the first step is to actually have an MSRV that isn't a lie.)