Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release #698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Feb 19, 2025

🤖 New release

  • salsa-macro-rules: 0.1.0 -> 0.1.1 (✓ API compatible changes)
  • salsa-macros: 0.18.0 -> 0.18.1
  • salsa: 0.18.0 -> 0.19.0 (⚠ API breaking changes)

salsa breaking changes

--- failure inherent_method_now_doc_hidden: inherent method #[doc(hidden)] added ---

Description:
A method or associated fn is now #[doc(hidden)], removing it from the crate's public API.
        ref: https://doc.rust-lang.org/rustdoc/write-documentation/the-doc-attribute.html#hidden
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/inherent_method_now_doc_hidden.ron

Failed in:
  Zalsa::add_or_lookup_jar_by_type in file /tmp/.tmpTvBBzd/salsa/src/zalsa.rs:199
  Zalsa::lookup_ingredient_mut in file /tmp/.tmpTvBBzd/salsa/src/zalsa.rs:250
  Zalsa::current_revision in file /tmp/.tmpTvBBzd/salsa/src/zalsa.rs:263
  Zalsa::last_changed_revision in file /tmp/.tmpTvBBzd/salsa/src/zalsa.rs:276

--- failure method_parameter_count_changed: pub method parameter count changed ---

Description:
A publicly-visible method now takes a different number of parameters.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#fn-change-arity
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/method_parameter_count_changed.ron

Failed in:
  salsa::plumbing::tracked_struct::IngredientImpl::tracked_field now takes 4 parameters instead of 5, in /tmp/.tmpKo0jYH/salsa/src/tracked_struct.rs:664
  salsa::plumbing::input::IngredientImpl::get_singleton_input now takes 2 parameters instead of 1, in /tmp/.tmpKo0jYH/salsa/src/input.rs:157

--- failure trait_added_supertrait: non-sealed trait added new supertraits ---

Description:
A non-sealed trait added one or more supertraits, which breaks downstream implementations of the trait
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#generic-bounds-tighten
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_added_supertrait.ron

Failed in:
  trait salsa::prelude::Accumulator gained UnwindSafe in file /tmp/.tmpKo0jYH/salsa/src/accumulator.rs:27
  trait salsa::plumbing::Accumulator gained UnwindSafe in file /tmp/.tmpKo0jYH/salsa/src/accumulator.rs:27
  trait salsa::Accumulator gained UnwindSafe in file /tmp/.tmpKo0jYH/salsa/src/accumulator.rs:27
  trait salsa::plumbing::SalsaStructInDb gained Sized in file /tmp/.tmpKo0jYH/salsa/src/salsa_struct.rs:7

--- failure trait_associated_type_added: non-sealed public trait added associated type without default value ---

Description:
A non-sealed trait has gained an associated type without a default value, which breaks downstream implementations of the trait
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_associated_type_added.ron

Failed in:
  trait associated type salsa::plumbing::SalsaStructInDb::MemoIngredientMap in file /tmp/.tmpKo0jYH/salsa/src/salsa_struct.rs:8

--- failure trait_method_added: pub trait method added ---

Description:
A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_method_added.ron

Failed in:
  trait method salsa::plumbing::Jar::id_struct_type_id in file /tmp/.tmpKo0jYH/salsa/src/ingredient.rs:45
  trait method salsa::plumbing::SalsaStructInDb::lookup_or_create_ingredient_index in file /tmp/.tmpKo0jYH/salsa/src/salsa_struct.rs:19
  trait method salsa::plumbing::SalsaStructInDb::cast in file /tmp/.tmpKo0jYH/salsa/src/salsa_struct.rs:64

--- failure trait_method_missing: pub trait method removed or renamed ---

Description:
A trait method is no longer callable, and may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_method_missing.ron

Failed in:
  method salsa_struct_type_id of trait Jar, previously in file /tmp/.tmpTvBBzd/salsa/src/ingredient.rs:29
  method lookup_ingredient_index of trait SalsaStructInDb, previously in file /tmp/.tmpTvBBzd/salsa/src/salsa_struct.rs:4

--- failure trait_missing: pub trait removed or renamed ---

Description:
A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.39.0/src/lints/trait_missing.ron

Failed in:
  trait salsa::plumbing::JarAux, previously in file /tmp/.tmpTvBBzd/salsa/src/ingredient.rs:33
Changelog

salsa-macro-rules

0.1.1 - 2025-02-27

Other

  • Remove unnecessary current_revision call from setup_interned_struct
  • Skip memo ingredient index mapping for non enum tracked functions
  • Trade off a bit of memory for more speed in MemoIngredientIndices
  • Introduce Salsa enums
  • Track revisions for tracked fields only
  • Fix bad-hash with in-place update
  • Automatically clear the cancellation flag when cancellation completes
  • Require mut Zalsa access for setting the lru limit
  • Split off revision bumping from zalsa_mut access

salsa-macros

0.18.1 - 2025-02-27

Fixed

  • fix enums bug

Other

  • address review comments
  • Skip memo ingredient index mapping for non enum tracked functions
  • Trade off a bit of memory for more speed in MemoIngredientIndices
  • Introduce Salsa enums
  • Track revisions for tracked fields only

salsa

0.19.0 - 2025-02-27

Fixed

  • fix typo
  • fix enums bug

Other

  • implement Update trait for IndexMap, and IndexSet
  • more correct bounds on Send and Sync implementation DeletedEntries
  • replace arc-swap with manual AtomicPtr
  • Remove unnecessary current_revision call from setup_interned_struct
  • Merge pull request #731 from Veykril/veykril/push-nzkwqzxxkxou
  • Remove some dynamically dispatched Database::event calls
  • Lazy fetching
  • Add small supertype input benchmark
  • Replace a DashMap with RwLock as writing is rare for it
  • address review comments
  • Skip memo ingredient index mapping for non enum tracked functions
  • Trade off a bit of memory for more speed in MemoIngredientIndices
  • Introduce Salsa enums
  • Cancel duplicate test workflow runs
  • implement Update trait for hashbrown::HashMap
  • Move unwind_if_revision_cancelled from ZalsaLocal to Zalsa
  • Don't clone strings in benchmarks
  • Merge pull request #714 from Veykril/veykril/push-synxntlkqqsq
  • Merge pull request #711 from Veykril/veykril/push-stmmwmtprovt
  • Merge pull request #715 from Veykril/veykril/push-plwpsqknwulq
  • Enforce unsafe_op_in_unsafe_fn
  • Remove some ZalsaDatabase::zalsa calls
  • Remove outdated FIXME
  • Replace IngredientCache lock with atomic primitive
  • Reduce method delegation duplication
  • Automatically clear the cancellation flag when cancellation completes
  • Allow trigger LRU eviction without increasing the current revision
  • Simplify Ingredient::reset_for_new_revision setup
  • Require mut Zalsa access for setting the lru limit
  • Split off revision bumping from zalsa_mut access
  • Update hashbrown (0.15) and hashlink (0.10)


This PR was generated with release-plz.

Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for salsa-rs canceled.

Name Link
🔨 Latest commit 4e6d8a5
🔍 Latest deploy log https://app.netlify.com/sites/salsa-rs/deploys/67c02a1833bfde000894dd36

@MichaReiser
Copy link
Contributor

Great changelog! Hehe, we should probably start paying a little more attention to our commit hygiene :)

@github-actions github-actions bot changed the title chore(salsa-macro-rules): release v0.1.0 chore(salsa): release v0.18.1 Feb 20, 2025
@github-actions github-actions bot force-pushed the release-plz-2025-02-19T15-54-29Z branch from 77ba6ec to 617d3ad Compare February 20, 2025 08:31
@MichaReiser
Copy link
Contributor

Hmm. Any chance that release-plz is confused here because we have multiple crates? It only ever shows the changes of one crate whereas it should release them all at once (or have different PRs for the different crates?)

@MichaReiser
Copy link
Contributor

It would probably also be good to at least run the tests before every release:

https://release-plz.dev/docs/github/advanced#add-additional-checks-before-releasing

@github-actions github-actions bot changed the title chore(salsa): release v0.18.1 chore: release Feb 21, 2025
@github-actions github-actions bot force-pushed the release-plz-2025-02-19T15-54-29Z branch 21 times, most recently from 20ba786 to d62bed0 Compare February 26, 2025 14:53
@github-actions github-actions bot force-pushed the release-plz-2025-02-19T15-54-29Z branch from d62bed0 to 4e6d8a5 Compare February 27, 2025 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant