From 5ba8e8e160c84c43dd81ffd4d6ef850ce9ca0384 Mon Sep 17 00:00:00 2001 From: aviadhahami Date: Tue, 21 Jun 2022 13:43:58 +0300 Subject: [PATCH 1/3] deps: update bundled c-ares --- deps/c-ares | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/c-ares b/deps/c-ares index 809d5e8..9aacffe 160000 --- a/deps/c-ares +++ b/deps/c-ares @@ -1 +1 @@ -Subproject commit 809d5e84f3423ab8165650d923acb0e246cbd006 +Subproject commit 9aacffe56316f2a31c15409dff8b167c105fe785 From 7c92a696d2a00c3260d7f2bf811b9ba32a35f69c Mon Sep 17 00:00:00 2001 From: aviadhahami Date: Tue, 21 Jun 2022 14:07:51 +0300 Subject: [PATCH 2/3] tests: updated google TXT records for an outdated test --- tests/tests.py | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/tests/tests.py b/tests/tests.py index 164f1d0..abff8e6 100755 --- a/tests/tests.py +++ b/tests/tests.py @@ -300,16 +300,18 @@ def cb(result, errorno): self.wait() self.assertNoError(self.errorno) # > dig -t txt google.com - # google.com. 3593 IN TXT "docusign=05958488-4752-4ef2-95eb-aa7ba8a3bd0e" - # google.com. 3593 IN TXT "globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=" - # google.com. 3593 IN TXT "facebook-domain-verification=22rm551cu4k0ab0bxsw536tlds4h95" - # google.com. 3593 IN TXT "docusign=1b0a6754-49b1-4db5-8540-d2c12664b289" - # google.com. 3593 IN TXT "MS=E4A68B9AB2BB9670BCE15412F62916164C0B20BB" - # google.com. 3593 IN TXT "v=spf1 include:_spf.google.com ~all" - # google.com. 3593 IN TXT "google-site-verification=wD8N7i1JTNTkezJ49swvWW48f8_9xveREV4oB-0Hf5o" - # google.com. 3593 IN TXT "apple-domain-verification=30afIBcvSuDV2PLX" - # google.com. 3593 IN TXT "google-site-verification=TV9-DBe4R80X4v0M4U_bd_J9cpOJM0nikft0jAgjmsQ" - self.assertEqual(len(self.result), 9) + # google.com. 3270 IN TXT "google-site-verification=TV9-DBe4R80X4v0M4U_bd_J9cpOJM0nikft0jAgjmsQ" + # google.com. 3270 IN TXT "atlassian-domain-verification=5YjTmWmjI92ewqkx2oXmBaD60Td9zWon9r6eakvHX6B77zzkFQto8PQ9QsKnbf4I" + # google.com. 3270 IN TXT "docusign=05958488-4752-4ef2-95eb-aa7ba8a3bd0e" + # google.com. 3270 IN TXT "facebook-domain-verification=22rm551cu4k0ab0bxsw536tlds4h95" + # google.com. 3270 IN TXT "google-site-verification=wD8N7i1JTNTkezJ49swvWW48f8_9xveREV4oB-0Hf5o" + # google.com. 3270 IN TXT "apple-domain-verification=30afIBcvSuDV2PLX" + # google.com. 3270 IN TXT "webexdomainverification.8YX6G=6e6922db-e3e6-4a36-904e-a805c28087fa" + # google.com. 3270 IN TXT "MS=E4A68B9AB2BB9670BCE15412F62916164C0B20BB" + # google.com. 3270 IN TXT "v=spf1 include:_spf.google.com ~all" + # google.com. 3270 IN TXT "globalsign-smime-dv=CDYX+XFHUw2wml6/Gb8+59BsH31KzUr6c1l2BPvqKX8=" + # google.com. 3270 IN TXT "docusign=1b0a6754-49b1-4db5-8540-d2c12664b289" + self.assertEqual(len(self.result), 11) def test_query_txt_bytes1(self): self.result, self.errorno = None, None From a17d09386a5c327d6ae01b88df08f7b2977b0193 Mon Sep 17 00:00:00 2001 From: aviadhahami Date: Tue, 21 Jun 2022 14:19:25 +0300 Subject: [PATCH 3/3] tests: ignoring 2 tests due to dead servers the two "expected-to-fail" tests fail due to dead servers. these needs to be fixed but are ignored now in favor of security --- tests/tests.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/tests/tests.py b/tests/tests.py index abff8e6..95b63ff 100755 --- a/tests/tests.py +++ b/tests/tests.py @@ -324,6 +324,11 @@ def cb(result, errorno): self.assertEqual(type(r), pycares.ares_query_txt_result) self.assertIsInstance(r.text, str) # it's ASCII + # The 2 tests below hit a dead end thus fail. Commenting for now as I couldn't find a live server + # that satisfies what the tests are looking for + + # FIXME: wide.com.es is a dead end! + @unittest.expectedFailure def test_query_txt_bytes2(self): self.result, self.errorno = None, None def cb(result, errorno): @@ -335,6 +340,8 @@ def cb(result, errorno): self.assertEqual(type(r), pycares.ares_query_txt_result) self.assertIsInstance(r.text, bytes) + # FIXME: "txt-non-ascii.dns-test.hmnid.ru" is a dead end! + @unittest.expectedFailure def test_query_txt_multiple_chunked_with_non_ascii_content(self): self.result, self.errorno = None, None def cb(result, errorno):