Skip to content

Commit faab689

Browse files
aviadhahamisaghul
authored andcommitted
tests: ignoring 2 tests due to dead servers
the two "expected-to-fail" tests fail due to dead servers. these needs to be fixed but are ignored now in favor of security
1 parent 8026e66 commit faab689

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

tests/tests.py

+7
Original file line numberDiff line numberDiff line change
@@ -324,6 +324,11 @@ def cb(result, errorno):
324324
self.assertEqual(type(r), pycares.ares_query_txt_result)
325325
self.assertIsInstance(r.text, str) # it's ASCII
326326

327+
# The 2 tests below hit a dead end thus fail. Commenting for now as I couldn't find a live server
328+
# that satisfies what the tests are looking for
329+
330+
# FIXME: wide.com.es is a dead end!
331+
@unittest.expectedFailure
327332
def test_query_txt_bytes2(self):
328333
self.result, self.errorno = None, None
329334
def cb(result, errorno):
@@ -335,6 +340,8 @@ def cb(result, errorno):
335340
self.assertEqual(type(r), pycares.ares_query_txt_result)
336341
self.assertIsInstance(r.text, bytes)
337342

343+
# FIXME: "txt-non-ascii.dns-test.hmnid.ru" is a dead end!
344+
@unittest.expectedFailure
338345
def test_query_txt_multiple_chunked_with_non_ascii_content(self):
339346
self.result, self.errorno = None, None
340347
def cb(result, errorno):

0 commit comments

Comments
 (0)