Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

c_lib SConscript doesn't always copy new libcsage.dylib on a sage -b #555

Closed
craigcitro opened this issue Sep 1, 2007 · 8 comments
Closed

Comments

@craigcitro
Copy link
Member

If you have two branches, and you edit libcsage.dylib in one, then sage -b to the other, it doesn't (always? ever?) copy over the appropriate libcsage.dylib to /SAGE_ROOT/local/lib.

Component: packages: standard

Issue created by migration from https://trac.sagemath.org/ticket/555

@craigcitro craigcitro added this to the sage-2.8.4 milestone Sep 1, 2007
@craigcitro craigcitro self-assigned this Sep 1, 2007
@williamstein

This comment has been minimized.

@craigcitro
Copy link
Member Author

comment:2

I'm pretty sure this is fixed. Basically, the problem is that scons doesn't want to look at a remote file (in our case $SAGE_ROOT/local/lib/libcsage.dylib) and see if it's up to date. The fix: just force it to copy the file over every time. Not the most elegant, but it works.

hg bundle is attached.

@williamstein
Copy link
Contributor

comment:3

I can't apply this patch no matter what I try...

@craigcitro
Copy link
Member Author

Attachment: trac_555.hg.gz

@craigcitro
Copy link
Member Author

Attachment: ticket_555.patch.gz

patch for same hg bundle below

@craigcitro
Copy link
Member Author

Attachment: total_trac_555_localbin.hg.gz

@craigcitro
Copy link
Member Author

comment:4

Attachment: total_trac_555.hg.gz

Attached two new bundles, total_trac_555.hg and total_trac_555_localbin.hg. The first is against the main sage repo, and the second is for $SAGE_ROOT/local/bin, as you might guess from the name. These take you from a clean 2.8.3 install to a version with a fully working c_lib recompilation on branch switch setup, with very few spurious copies.

Let me know if people run into trouble; if you want to test it, do the following: make a new branch (called, say, foo) and apply the hg bundle, and then clone that (maybe call that bar). Then switch back and forth between foo and bar, and make sure that you see libcsage.dylib getting copied (along with a bunch of include files) every time you switch branches.

@williamstein
Copy link
Contributor

comment:5

I've pushed this all into the official repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants