Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTL's DoConfig errors out when NTL is build with dependencies in a directory containing [-h|help|-help|--help] #5040

Closed
williamstein opened this issue Jan 20, 2009 · 3 comments

Comments

@williamstein
Copy link
Contributor

If you build sage and the directory path contains a "-h" anywhere in it, then NTL's perl DoConfig script displays a help message and exists. This totally breaks building sage. The code at fault is:


   if ($arg =~ '-h|help|-help|--help') {
      system("more ../doc/config.txt");
      exit;
   }

In particular, PREFIX will get passed in and if your directory were, e.g,. build-sage-help-me-foobar then Sage won't work.

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/5040

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 29, 2009

comment:1

The spkg at

http://sage.math.washington.edu/home/mabshoff/release-cycles-3.3/alpha3/ntl-5.4.2.p5.spkg

fixes the problem by removing the help option for now. Note that this spkg also fixes #4978.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title Bug in NTL's ./configure NTL's DoConfig errors out when NTL is build with dependencies in a directory containing [-h|help|-help|--help] Jan 29, 2009
@sagetrac-cwitty
Copy link
Mannequin

sagetrac-cwitty mannequin commented Jan 29, 2009

comment:2

Code looks good. The new spkg does build, and relevant doctests still pass after rebuilding NTL-related .pyx files.

Positive review.

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Jan 29, 2009

comment:3

Merged in Sage 3.3.alpha3.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Jan 29, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant