You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
sage: id = matrix(ZZ, 2, 2, [[1, 0], [0, 1]])
sage: id.left_kernel()
Traceback
...
TypeError: Argument K (= Integer Ring) must be a field.
On the other hand, id.right_kernel() and id.kernel() both work, and id.kernel() actually computes the left kernel. Note also that the documentation for both left_kernel and right_kernel says that the answer will be a vector space, not a module over the integers; this should be fixed, too.
Looks good, all tests passed. A few comments: the documentation still says "vector space" when computing the kernel of an integer matrix, but I can live with that. Perhaps more seriously, if you don't apply patch #5089, then computing the kernel (or left_kernel or right_kernel) of a sparse integer matrix leads to a segmentation fault. Does this need to be investigated further?
jhpalmieri
changed the title
kernels of integer matrices
[mostly positive review] kernels of integer matrices
Jan 24, 2009
Since #5089 is being merged I am changing this to a positive review. The documentation issue about vector spaces vs. modules should be addressed via a followup ticket.
Cheers,
Michael
sagetrac-mabshoffmannequin
changed the title
[mostly positive review] kernels of integer matrices
[with patch positive review] kernels of integer matrices
Jan 24, 2009
On the other hand,
id.right_kernel()
andid.kernel()
both work, andid.kernel()
actually computes the left kernel. Note also that the documentation for both left_kernel and right_kernel says that the answer will be a vector space, not a module over the integers; this should be fixed, too.Component: linear algebra
Keywords: matrix, kernel
Issue created by migration from https://trac.sagemath.org/ticket/5001
The text was updated successfully, but these errors were encountered: