sage/modules/vector_modn_sparse_c.pxi: init_c_vector_modint leaks leak memory in case of OverflowError

[sagetrac-mabshoff]

Look at:

cdef int init_c_vector_modint(c_vector_modint* v, int p, Py_ssize_t degree,
                              Py_ssize_t num_nonzero) except -1:
    """
    Initialize a c_vector_modint.
    """
    if (allocate_c_vector_modint(v, num_nonzero) == -1):
        raise MemoryError, "Error allocating memory for sparse vector."
    if p > 46340:
        raise OverflowError, "The prime must be <= 46340."
    v.num_nonzero = num_nonzero
    v.degree = degree
    v.p = p
    return 0

On OverflowError v is leaked. Switching check and allocation will fix the problem.

Cheers,

Michael

Component: memleak

Issue created by migration from https://trac.sagemath.org/ticket/4962

[rlmill]

comment:2

Attachment: trac-4962.patch.gz

[sagetrac-mabshoff]

comment:3

Positive review even though the author did not fix it as I suggested :)

Cheers,

Michael

[sagetrac-mabshoff]

comment:4

Merged in Sage 3.3.alpha2