notebook -- copying a worksheet on worksheet listings page results in the new worksheet being listed as running

[TimothyClemans]

Why is the new worksheet, copy of another worksheet, running? It hasn't been accessed by the user.

Component: notebook

Issue created by migration from https://trac.sagemath.org/ticket/4011

[TimothyClemans]

comment:1

Please delete sage-4011_1.patch.

Patch sage-4011_1.patch doesn't seem to resolve the problem.

[mwhansen]

Attachment: trac_4011.patch.gz

[mwhansen]

comment:2

I've added a test to my Selenium test suite for this since it requires the Javascript to run.

[jasongrout]

comment:3

This might be really nitpicky, but can we make the code not have a double negative? I.e., if no_load is in ctx, rather than if no_load not in ctx. Having a double negative makes the code a bit more confusing.

[jasongrout]

comment:4

And if you're modifying the patch anyway, you might fix the typo in the docs in js.py for this function: worsheet -> worksheet.

[TimothyClemans]

Attachment: trac_4135.2.patch.gz

[TimothyClemans]

comment:5

Attachment: trac_4011.2.patch.gz

Apply trac_4011.2.patch

[sagetrac-mabshoff]

comment:6

Merged trac_4011.2.patch in Sage 3.4.1.alpha0.

Cheers,

Michael