Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notebook -- sometimes published worksheets are listed as being published by pub. #3820

Closed
williamstein opened this issue Aug 12, 2008 · 6 comments
Closed

notebook -- sometimes published worksheets are listed as being published by pub. #3820

williamstein opened this issue Aug 12, 2008 · 6 comments
Assignees
@mwhansen
Labels
c: user interface p: minor / 4 t: bug
Milestone
sage-3.4.1

Comments

@williamstein
Copy link
Contributor

notebook -- sometimes published worksheets are listed as being published by pub; this should never be the case.

Component: notebook

Issue created by migration from https://trac.sagemath.org/ticket/3820
@williamstein williamstein added this to the sage-3.4.2 milestone Aug 12, 2008
@mwhansen
Copy link
Contributor

comment:1

I've added a test in the selenium suite for this.

@mwhansen mwhansen assigned mwhansen and unassigned boothby Jan 24, 2009
@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Feb 2, 2009

comment:2

This patch needs to be rebased unless there is some dependency I am not aware of:

sage-3.3.alpha4/devel/sage$ patch -p1 < trac_3820.patch\?format\=raw 
patching file sage/server/notebook/templates/worksheet_listing.html
Hunk #1 succeeded at 130 (offset 1 line).
Hunk #2 FAILED at 178.
1 out of 2 hunks FAILED -- saving rejects to file sage/server/notebook/templates/worksheet_listing.html.rej

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin changed the title notebook -- sometimes published worksheets are listed as being published by pub. [needs rebase] notebook -- sometimes published worksheets are listed as being published by pub. Feb 2, 2009
@mwhansen
Copy link
Contributor

Attachment: trac_3820.patch.gz

@mwhansen
Copy link
Contributor

comment:3

I've put up a rebased patch which applies against rc0.

@mwhansen mwhansen changed the title [needs rebase] notebook -- sometimes published worksheets are listed as being published by pub. notebook -- sometimes published worksheets are listed as being published by pub. Feb 15, 2009
@TimothyClemans
Copy link
Mannequin

TimothyClemans mannequin commented Mar 16, 2009

comment:4

looks good

  • note that if original worksheet is deleted then the owner cell on the published worksheets page is blank

@sagetrac-mabshoff
Copy link
Mannequin

sagetrac-mabshoff mannequin commented Mar 25, 2009

comment:5

Merged in Sage 3.4.1.alpha0.

Cheers,

Michael

@sagetrac-mabshoff sagetrac-mabshoff mannequin closed this as completed Mar 25, 2009
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-3.4.2, sage-3.4.1 Mar 25, 2009
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mwhansen mwhansen

Labels
c: user interface p: minor / 4 t: bug
Projects
None yet
Milestone
sage-3.4.1
Development

No branches or pull requests
3 participants
@mwhansen @boothby @williamstein