-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove (object) in sage_docbuild #34366
Comments
Branch: u/chapoton/34366 |
New commits:
|
Commit: |
This comment has been minimized.
This comment has been minimized.
comment:3
Why not remove parentheses too? |
comment:4
The doctest failure in |
comment:5
the error in plot seems to be random and unrelated to the present ticket |
comment:6
I think this should be good to go. The failure in plot is random, and have been seen elsewhere if I remember correctly. |
comment:8
Would you answer this? |
comment:9
Well, this is a matter of taste. I prefer to keep |
comment:10
Replying to @fchapoton:
I doubt it. No parentheses indicate no inheritance. Dangling To see it as a matter of taste, there should be many examples in python docs or in sage. |
comment:11
There is no style guide on this AFAIK, so #34348 applies. |
Reviewer: Kwankyu Lee, Travis Scrimshaw |
comment:15
Inheriting from other classes is
so, to me, inheriting from no other class with
seems consistent. Likewise, functions definitions and calls use parentheses, |
Changed branch from u/chapoton/34366 to |
after that, there remains only
and
CC: @tscrim @slel @kliem @mkoeppe
Component: doctest framework
Author: Frédéric Chapoton
Branch/Commit:
16b8c4d
Reviewer: Kwankyu Lee, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/34366
The text was updated successfully, but these errors were encountered: