Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove (object) in sage_docbuild #34366

Closed
fchapoton opened this issue Aug 15, 2022 · 17 comments
Closed

remove (object) in sage_docbuild #34366

fchapoton opened this issue Aug 15, 2022 · 17 comments

Comments

@fchapoton
Copy link
Contributor

after that, there remains only

src/sage/misc/c3_controlled.pyx:class HierarchyElement(object, metaclass=ClasscallMetaclass):
src/sage/misc/classcall_metaclass.pyx:            sage: class FooNoInherits(object, metaclass=ClasscallMetaclass):
src/sage/misc/classcall_metaclass.pyx:            sage: class Foo2(object, metaclass=ClasscallMetaclass):
src/sage/misc/classcall_metaclass.pyx:            sage: class NOCALL(object, metaclass=ClasscallMetaclass):
src/sage/misc/classcall_metaclass.pyx:            sage: class Exc(object, metaclass=ClasscallMetaclass):
src/sage/misc/classcall_metaclass.pyx:class C2(object, metaclass=ClasscallMetaclass):
src/sage/misc/classcall_metaclass.pyx:class C3(object, metaclass = ClasscallMetaclass):
src/sage/misc/classcall_metaclass.pyx:class C2C(object, metaclass=ClasscallMetaclass):
src/sage/misc/classcall_metaclass.pyx:        sage: class PC(object, metaclass=ClasscallMetaclass):
src/sage/misc/nested_class.pyx:        sage: class ASuperClass(object, metaclass=NestedClassMetaclass):
src/sage/misc/nested_class.pyx:            sage: class A(object, metaclass=NestedClassMetaclass):
src/sage/misc/nested_class.pyx:class MainClass(object, metaclass=NestedClassMetaclass):

and

src/sage_setup/autogen/interpreters/generator.py:class InterpreterGenerator(object):
src/sage_setup/autogen/interpreters/instructions.py:class InstrSpec(object):
src/sage_setup/autogen/interpreters/memory.py:class MemoryChunk(object):
src/sage_setup/autogen/interpreters/specs/base.py:class InterpreterSpec(object):
src/sage_setup/autogen/interpreters/storage.py:class StorageType(object):

CC: @tscrim @slel @kliem @mkoeppe

Component: doctest framework

Author: Frédéric Chapoton

Branch/Commit: 16b8c4d

Reviewer: Kwankyu Lee, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34366

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34366

@fchapoton
Copy link
Contributor Author

New commits:

16b8c4dremove inheritance of object in sage_docbuild

@fchapoton
Copy link
Contributor Author

Commit: 16b8c4d

@fchapoton

This comment has been minimized.

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 15, 2022

comment:3

Why not remove parentheses too?

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 15, 2022

comment:4

The doctest failure in sage/plot/plot.py seems genuine.

@fchapoton
Copy link
Contributor Author

comment:5

the error in plot seems to be random and unrelated to the present ticket

@fchapoton
Copy link
Contributor Author

comment:6

I think this should be good to go. The failure in plot is random, and have been seen elsewhere if I remember correctly.

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 23, 2022

comment:8

Why not remove parentheses too?

Would you answer this?

@fchapoton
Copy link
Contributor Author

comment:9

Well, this is a matter of taste. I prefer to keep () for aesthetic reasons.

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 23, 2022

comment:10

Replying to @fchapoton:

Well, this is a matter of taste. I prefer to keep () for aesthetic reasons.

I doubt it. No parentheses indicate no inheritance. Dangling () looks just a mistake.

To see it as a matter of taste, there should be many examples in python docs or in sage.

@tscrim
Copy link
Collaborator

tscrim commented Aug 24, 2022

comment:11

There is no style guide on this AFAIK, so #34348 applies.

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 24, 2022

comment:12

Replying to @tscrim:

There is no style guide on this AFAIK, so #34348 applies.

Okay. Then I don't object.

@tscrim
Copy link
Collaborator

tscrim commented Aug 24, 2022

Reviewer: Kwankyu Lee, Travis Scrimshaw

@kwankyu
Copy link
Collaborator

kwankyu commented Aug 24, 2022

comment:14

Replying to @tscrim:

so #34348 applies.

#34348 is to be explicit about disputed styles. If this issue is on dispute again somewhere else, we may consider to put it to the section.

@slel
Copy link
Member

slel commented Aug 24, 2022

comment:15

Inheriting from other classes is

class This(That, Other):

so, to me, inheriting from no other class with

class This():

seems consistent.

Likewise, functions definitions and calls use parentheses,
whether or not there are arguments.

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/chapoton/34366 to 16b8c4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants