Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some details in riemann_surface.py #34361

Closed
fchapoton opened this issue Aug 14, 2022 · 8 comments
Closed

some details in riemann_surface.py #34361

fchapoton opened this issue Aug 14, 2022 · 8 comments
Labels
c: algebraic geometry p: minor / 4 t: enhancement
Milestone
sage-9.7

Comments

@fchapoton
Copy link
Contributor

namely typos and partial pep8 cleanup

CC: @tscrim @kwankyu @slel @dcoudert

Component: algebraic geometry

Author: Frédéric Chapoton

Branch/Commit: d324476

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/34361
@fchapoton fchapoton added this to the sage-9.7 milestone Aug 14, 2022
@fchapoton
Copy link
Contributor Author

Commit: d324476

@fchapoton
Copy link
Contributor Author

Branch: u/chapoton/34361

@fchapoton
Copy link
Contributor Author

New commits:

d324476a few details in riemann_surface.py

@fchapoton
Copy link
Contributor Author

comment:2

all green lights, so please review

@tscrim
Copy link
Collaborator

tscrim commented Aug 15, 2022

comment:3

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Aug 15, 2022

Reviewer: Travis Scrimshaw

@fchapoton
Copy link
Contributor Author

comment:4

Arigato, Travis

@vbraun
Copy link
Member

vbraun commented Aug 30, 2022

Changed branch from u/chapoton/34361 to d324476

@vbraun vbraun closed this as completed in 0c4561b Aug 30, 2022
@vbraun vbraun mentioned this issue Aug 29, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: algebraic geometry p: minor / 4 t: enhancement
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @tscrim @fchapoton