-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pycodestyle cleanup in src/sage/graphs/generic_graph.py (part 1) #34318
Milestone
Comments
New commits:
|
Branch: public/graphs/34318_gen1 |
Commit: |
comment:2
I would take the occasion to fix the pyflakes hint as well, for example diff --git a/src/sage/graphs/generic_graph.py b/src/sage/graphs/generic_graph.py
index b8a2a920da..7063a348af 100644
--- a/src/sage/graphs/generic_graph.py
+++ b/src/sage/graphs/generic_graph.py
@@ -10871,7 +10871,7 @@ class GenericGraph(GenericGraph_pyx):
except AttributeError:
assoc = self._assoc = {}
- self._assoc[vertex] = object
+ assoc[vertex] = object
If done, this can get a positive review. |
Reviewer: Sebastian Oehms |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:4
I fixed the issue. Thank you for the review. |
Changed branch from public/graphs/34318_gen1 to |
This was referenced Aug 29, 2022
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
start cleaning
src/sage/graphs/generic_graph.py
Component: graph theory
Author: David Coudert
Branch/Commit:
328cc6a
Reviewer: Sebastian Oehms
Issue created by migration from https://trac.sagemath.org/ticket/34318
The text was updated successfully, but these errors were encountered: