Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix pyflakes warnings in src/sage/misc/cython.py #34061

Closed
seblabbe opened this issue Jun 24, 2022 · 10 comments
Closed

fix pyflakes warnings in src/sage/misc/cython.py #34061

seblabbe opened this issue Jun 24, 2022 · 10 comments
Labels
p: major / 3 t: bug
Milestone
sage-9.7

Comments

@seblabbe
Copy link
Contributor

From #33029:

src/sage/env.py:32:1 'sage' imported but unused
src/sage/misc/cython.py:295:9 'setuptools' imported but unused
src/sage/misc/sagedoc.py:791:9 'sage.all' imported but unused
src/sage/misc/sagedoc.py:969:5 local variable 'html_results' is assigned to but never used

Component: misc

Author: Sébastien Labbé

Branch/Commit: 201dea8

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/34061
@seblabbe seblabbe added this to the sage-9.7 milestone Jun 24, 2022
@seblabbe
Copy link
Contributor Author

Commit: b48774a

@seblabbe
Copy link
Contributor Author

Branch: u/slabbe/34061

@seblabbe
Copy link
Contributor Author

New commits:

b48774a34061: fix pyflakes warning in misc/cython.py

@seblabbe
Copy link
Contributor Author

Author: Sébastien Labbé

@seblabbe
Copy link
Contributor Author

comment:2

I fixed the one in misc/cython.py, but left the other unchanged because I don't think it is safe to change them.

@seblabbe seblabbe changed the title fix pyflakes warnings in src/sage/misc/sagedoc.py and src/sage/misc/cython.py fix pyflakes warnings in src/sage/misc/cython.py Jun 24, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 7, 2022

Changed branch from u/slabbe/34061 to u/mkoeppe/34061

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 7, 2022

Changed commit from b48774a to 201dea8

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 7, 2022

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 7, 2022

New commits:

201dea8src/sage/misc/cython.py: Remove outdated comment

@vbraun
Copy link
Member

vbraun commented Jul 9, 2022

Changed branch from u/mkoeppe/34061 to 201dea8

@vbraun vbraun closed this as completed in 9c530f7 Jul 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @seblabbe @mkoeppe