Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.misc.cython: Replace use of SPYX_TMP by a new cached function in sage.misc.temporary_file #33793

Closed
mkoeppe opened this issue May 4, 2022 · 6 comments
Closed

sage.misc.cython: Replace use of SPYX_TMP by a new cached function in sage.misc.temporary_file #33793

mkoeppe opened this issue May 4, 2022 · 6 comments
Labels
p: major / 3 t: enhancement t: refactoring
Milestone
sage-9.7

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 4, 2022

(split out from #33213)

CC: @orlitzky

Component: refactoring

Author: Michael Orlitzky

Branch/Commit: fc25b79

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/33793
@mkoeppe mkoeppe added this to the sage-9.7 milestone May 4, 2022
@orlitzky
Copy link
Contributor

orlitzky commented May 4, 2022

Branch: u/mjo/ticket/33793

@orlitzky
Copy link
Contributor

orlitzky commented May 4, 2022

New commits:

202485fTrac #33793: replace SAGE_TMP in SPYX_TMP.
827c527Trac #33793: move spyx_tmp() to sage.misc.temporary_file.
fc25b79Trac #33793: cache spyx_tmp() by hand.

@orlitzky
Copy link
Contributor

orlitzky commented May 4, 2022

Commit: fc25b79

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 4, 2022

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 4, 2022

comment:3

Looking great

@vbraun
Copy link
Member

vbraun commented May 22, 2022

Changed branch from u/mjo/ticket/33793 to fc25b79

@vbraun vbraun closed this as completed in 7037fba May 22, 2022
This was referenced May 22, 2022
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
sage-9.7
Development

No branches or pull requests
3 participants
@vbraun @orlitzky @mkoeppe