Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage.libs.ecl, sage.interfaces.maxima*: Do not use ECL_TMP #33790

Closed
mkoeppe opened this issue May 3, 2022 · 13 comments
Closed

sage.libs.ecl, sage.interfaces.maxima*: Do not use ECL_TMP #33790

mkoeppe opened this issue May 3, 2022 · 13 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 3, 2022

(split out from #33213)

We have historically massaged TMPDIR and TMP when interfacing with ECL to ensure that SAGE_TMP was used consistently for temporary
files. Simply removing this code seems to do the trick, since ECL
wants to use the system location by default.

Depends on #33829

CC: @orlitzky @spaghettisalat @nbruin

Component: interfaces

Author: Michael Orlitzky

Branch/Commit: 4610b1c

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/33790

@mkoeppe mkoeppe added this to the sage-9.6 milestone May 3, 2022
@orlitzky
Copy link
Contributor

orlitzky commented May 3, 2022

comment:1

The fallback within ECL is a little naive, to /tmp if TMPDIR is unset. But I think that should work on all of our supported platforms, and the GH actions didn't turn up any problems.

If not we could pass in tempfile.gettempdir() from python instead.

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 May 3, 2022
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 9, 2022

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 9, 2022

Commit: 1a2bea0

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 9, 2022

New commits:

1a2bea0Trac #33213: replace ECL_TMP (based on SAGE_TMP) in maxima/ecl interfaces.

@mkoeppe

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Jun 13, 2022

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jun 13, 2022

comment:5

rebased over #33829 (and Sage 9.7.beta2)


New commits:

818410fTrac #33213: replace SAGE_TMP in the isgci database download routine.
71c9325Trac #33213: replace SAGE_TMP in GLPK graph backend doctests.
08213faTrac #33213: replace SAGE_TMP in graph doctests.
976f0d6remove crud after except, make it pass
4610b1cTrac #33213: replace ECL_TMP (based on SAGE_TMP) in maxima/ecl interfaces.

@dimpase
Copy link
Member

dimpase commented Jun 13, 2022

Changed commit from 1a2bea0 to 4610b1c

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 13, 2022

comment:6

I think you got the dependencies the wrong way around

@dimpase
Copy link
Member

dimpase commented Jun 13, 2022

comment:7

should be like this, sorry.

@dimpase
Copy link
Member

dimpase commented Jun 13, 2022

Dependencies: #33829

@vbraun
Copy link
Member

vbraun commented Jun 19, 2022

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants