Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter singular system package out of tox.ini for homebrew #32784

Closed
orlitzky opened this issue Oct 27, 2021 · 11 comments
Closed

Filter singular system package out of tox.ini for homebrew #32784

orlitzky opened this issue Oct 27, 2021 · 11 comments

Comments

@orlitzky
Copy link
Contributor

As a follow-up to #29024, we prevent the system singular from being used to run GH actions when the homebrew prefix is not /usr/local (which causes problems for its singular package).

CC: @mkoeppe @dimpase

Component: build

Branch/Commit: u/mjo/ticket/32784 @ e4aa49e

Reviewer: Michael Orlitzky

Issue created by migration from https://trac.sagemath.org/ticket/32784

@orlitzky orlitzky added this to the sage-9.5 milestone Oct 27, 2021
@orlitzky
Copy link
Contributor Author

comment:1

Untested, needs a run on GH obviously...


New commits:

030ec23Trac #32784: filter singular in tox.ini for homebrew.

@orlitzky
Copy link
Contributor Author

Commit: 030ec23

@orlitzky
Copy link
Contributor Author

Branch: u/mjo/ticket/32784

@orlitzky
Copy link
Contributor Author

Author: Michael Orlitzky

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 27, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

e4aa49eTrac #32784: filter singular in tox.ini for homebrew.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 27, 2021

Changed commit from 030ec23 to e4aa49e

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2021

comment:3

Turns out this patch is not needed for our GH Actions.

Homebrew's from-source installation of singular only fails if there's already a homebrew-installed flint in /usr/local (or any of the paths of Singular's DEFAULT_CHECKING_PATH.

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 19, 2021

comment:4

Homebrew does not like people to report bugs with the from-source installation, so perhaps instead we should send them a PR that adds flint as a dependency to https://github.com/Homebrew/homebrew-core/blob/HEAD/Formula/singular.rb

@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 21, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 May 3, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 29, 2023

Changed author from Michael Orlitzky to none

@mkoeppe
Copy link
Contributor

mkoeppe commented Jan 29, 2023

comment:9

No longer needed.

@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
@orlitzky
Copy link
Contributor Author

Reviewer: Michael Orlitzky

@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants