-
-
Notifications
You must be signed in to change notification settings - Fork 541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update scipy 1.7.x; add pythran package (scipy prerequisite) #32105
Comments
comment:2
NumPy 1.21.1 was released.
|
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Commit: |
This comment has been minimized.
This comment has been minimized.
Branch pushed to git repo; I updated commit sha1. New commits:
|
Author: Matthias Koeppe |
This comment has been minimized.
This comment has been minimized.
Reviewer: François Bissey |
comment:14
LGTM |
comment:15
|
comment:16
Indeed, from https://github.com/serge-sans-paille/pythran/blob/0.9.12.post1/requirements.txt:
|
comment:33
In the meantime new versions have come out |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:35
Replying to @vbraun:
I can reproduce those failures and they are trivial:
Doesn't require a distclean in my case. I have no idea why this is happening now and how to determine when deprecation messages are raised and when not. For some reason it changed now. |
comment:36
This has nothing to do with the current ticket. Something change in the new develop: On debian buster I get (not on ubuntu bionic):
|
comment:37
Sorry about the mess. It has something to do with the ticket. When running on |
Changed branch from u/mkoeppe/numpy_1_21_x__scipy_1_7_x to u/gh-kliem/numpy_1_21_x__scipy_1_7_x |
comment:38
Don't ask me why those deprecation warnings are somewhat random. They are given in each case, but sometimes they are given again and sometimes not and for some strange reason the current branch changed that. I pushed a patch that works on top of develop and on this ticket. New commits:
|
Changed author from Matthias Koeppe to Matthias Koeppe, Jonathan Kliem |
comment:39
Try if using |
comment:40
Not really. It only changes the stacklevel. Then there are two failures each in the files, one of which is also on develop. So it remains that we must have a workaround for the other 3 cases. |
comment:41
LGTM, thanks. |
Changed reviewer from François Bissey, Dima Pasechnik to François Bissey, Dima Pasechnik, Matthias Koeppe |
comment:42
I missed that last commit. I guess I am quite busy elsewhere. I would have treated all those like the second block
I have noticed this very failure in sage-on-gentoo for the last couple of weeks wondering where it was coming from. I was tempted to add the deprecation warning to the output when I noticed that some earlier tests already had it. So, it followed the pattern of one warning per session and somehow we are not having one session anymore. I think the current branch will work because this is the "new stable", rather than being unstable. If I am wrong and it is unstable, we can expect failures on some systems because a warning was displayed that wasn't expected. |
comment:43
Bugfix release SciPy 1.7.3 was just released, |
comment:44
Current branch is in Volker's merging branch, so it will need to be in a follow up unless Volker finds a reason to reject it. From my perspective in sage-on-gentoo the current branch is all good. |
Changed branch from u/gh-kliem/numpy_1_21_x__scipy_1_7_x to |
https://docs.scipy.org/doc/scipy/release.1.7.1.html
scipy has a new build requirement: pythran https://github.com/scipy/scipy/blob/master/pyproject.toml
Depends on #32488
CC: @kiwifb @antonio-rojas @dimpase @kliem
Component: packages: standard
Author: Matthias Koeppe, Jonathan Kliem
Branch/Commit:
6f5b6f7
Reviewer: François Bissey, Dima Pasechnik, Matthias Koeppe
Issue created by migration from https://trac.sagemath.org/ticket/32105
The text was updated successfully, but these errors were encountered: