Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some raw string for pdf doc building in sage-on-gentoo #31032

Closed
kiwifb opened this issue Dec 9, 2020 · 15 comments
Closed

some raw string for pdf doc building in sage-on-gentoo #31032

kiwifb opened this issue Dec 9, 2020 · 15 comments

Comments

@kiwifb
Copy link
Member

kiwifb commented Dec 9, 2020

BAck in sage 9.1 we had issues with building pdf docs because of missing raw strings.

Some issues that were also happening in vanilla sage have been fixed and merged but sage-on-gentoo continued to carry a few extra ones.

This ticket is to merge those leftovers.

Component: documentation

Keywords: sd111

Author: François Bissey

Branch/Commit: 27aee93

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/31032

@kiwifb kiwifb added this to the sage-9.3 milestone Dec 9, 2020
@kiwifb
Copy link
Member Author

kiwifb commented Dec 9, 2020

New commits:

d019743use some more raw strings for pdf build on Gentoo

@kiwifb
Copy link
Member Author

kiwifb commented Dec 9, 2020

Branch: u/fbissey/trac31032

@kiwifb
Copy link
Member Author

kiwifb commented Dec 9, 2020

Author: François Bissey

@kiwifb
Copy link
Member Author

kiwifb commented Dec 9, 2020

Commit: d019743

@fchapoton
Copy link
Contributor

comment:2

really keeping the double slash here in \\cdot ?

@kiwifb
Copy link
Member Author

kiwifb commented Dec 9, 2020

comment:3

Replying to @fchapoton:

really keeping the double slash here in \\cdot ?

I'd have to check, things were not failing on it so I may not have paid as much attention to it as I should have. But it does look suspicious.

@kiwifb
Copy link
Member Author

kiwifb commented Dec 9, 2020

comment:4

I introduced those back in sage 8.3 in fact, 9.1 is the latest time it was rebased. cschwan/sage-on-gentoo#509

And it was glossed over because it didn't cause anything to break. But it probably looks weird. I'll look at it tomorrow.

@kiwifb
Copy link
Member Author

kiwifb commented Dec 9, 2020

comment:5

I confirm, it looks incorrect since it is all escaped. Preparing a new commit.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2020

Changed commit from d019743 to 27aee93

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 9, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

27aee93correct the handling of cdot in raw string

@kiwifb
Copy link
Member Author

kiwifb commented Dec 9, 2020

comment:7

Fixed.

@fchapoton
Copy link
Contributor

comment:8

ok, merci

@fchapoton
Copy link
Contributor

Reviewer: Frédéric Chapoton

@mkoeppe
Copy link
Contributor

mkoeppe commented Dec 10, 2020

Changed keywords from none to sd111

@vbraun
Copy link
Member

vbraun commented Dec 14, 2020

Changed branch from u/fbissey/trac31032 to 27aee93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants