Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fix for Python bug #20108 #21552

Closed
jdemeyer opened this issue Sep 21, 2016 · 8 comments
Closed

Add a fix for Python bug #20108 #21552

jdemeyer opened this issue Sep 21, 2016 · 8 comments

Comments

@jdemeyer
Copy link
Contributor

ipywidgets uses inspect.getcallargs which has a subtle bug in case the inspected function has a func keyword argument: http://bugs.python.org/issue20108

This is fixed in Python 3.3 and later. We can easily backport the fix to Python 2.7.

While I'm at it, I also removed sdist.patch (which was about .hg directories and is clearly no longer relevant) and renamed some patches with the Python issue number.

Note to the release manager: ideally, this would be merged together with #21441 since both tickets trigger recompilation of all Python packages.

Upstream: Fixed upstream, in a later stable release.

CC: @EmmanuelCharpentier

Component: packages: standard

Author: Jeroen Demeyer

Branch/Commit: cf0621d

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/21552

@jdemeyer
Copy link
Contributor Author

@jdemeyer
Copy link
Contributor Author

New commits:

cf0621dFix Python bug #20108: getcallargs() with func keyword

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Contributor Author

Commit: cf0621d

@jdemeyer

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Oct 6, 2016

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 6, 2016

comment:5

Good for upstream, so good for Sage.

@vbraun
Copy link
Member

vbraun commented Oct 11, 2016

Changed branch from u/jdemeyer/add_a_fix_for_python_bug__20108 to cf0621d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants