Drop return type from arithmetic methods in coercion model

[jdemeyer]

Replace

cpdef ModuleElement _add_(left, ModuleElement right)

by

cpdef _add_(left, ModuleElement right)

and similar. The return type serves no purpose:

1. if you really do need any information of the return type, then something like ModuleElement is too generic anyway.
2. it forces Cython to add some checks that the returned value is of the correct type, so it might actually slow down things.

Also remove the superfluous declarations of these methods in other .pxd files.

CC: @videlec

Component: coercion

Keywords: days74

Author: Jeroen Demeyer

Branch: 56776e2

Reviewer: Marc Mezzarobba

Issue created by migration from https://trac.sagemath.org/ticket/20740

[jdemeyer]

comment:3

(edit: wrong ticket)

[jdemeyer]

Branch: u/jdemeyer/drop_return_type

[jdemeyer]

New commits:

56776e2

Drop return type from single-underscore arithmetic methods

[jdemeyer]

Commit: 56776e2

[jdemeyer]

Changed keywords from none to days74

[mezzarobba]

comment:7

Sounds convincing, though I would have preferred someone with stronger Cython-fu than me to review the ticket :-). This does make a few generated C files a couple hundred lines smaller, but I didn't notice any significant performance change (either way).

[mezzarobba]

Reviewer: Marc Mezzarobba

[jdemeyer]

comment:9

Replying to @mezzarobba:

but I didn't notice any significant performance change (either way).

I'm not surprised. The overhead of these checks should be small compared to the actual operation.

Thanks for the review of this and related tickets.

[vbraun]

Changed branch from u/jdemeyer/drop_return_type to 56776e2

[williamstein]

Changed commit from 56776e2 to none

[williamstein]

comment:12

test