Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't set CCACHE_DIR #13938

Closed
jdemeyer opened this issue Jan 10, 2013 · 13 comments
Closed

Don't set CCACHE_DIR #13938

jdemeyer opened this issue Jan 10, 2013 · 13 comments

Comments

@jdemeyer
Copy link

This is a follow-up to #13032. After consulting sage-devel, it seems like a bad idea to set CCACHE_DIR unconditionally, so let's not do this.

Blocker because #13032 is a regression for people using a system-wide ccache installation.

optional spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/ccache-3.1.9.spkg

apply: attachment: 13938_ccache_default_dir.patch to the SAGE_ROOT repository.

CC: @ppurka

Component: build

Author: Jeroen Demeyer

Reviewer: R. Andrew Ohana, Punarbasu Purkayastha

Merged: sage-5.6.rc0

Issue created by migration from https://trac.sagemath.org/ticket/13938

@jdemeyer
Copy link
Author

comment:1

Attachment: 13938_ccache_default_dir.patch.gz

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer

This comment has been minimized.

@jdemeyer
Copy link
Author

Attachment: ccache-3.1.9.diff.gz

Diff for the ccache spkg, for review only

@ohanar
Copy link
Member

ohanar commented Jan 10, 2013

comment:6

This appears to implement (1) from the sage-devel discussion, but to me it seemed like (3) was more the consensus from that thread. If (1) is the consensus, then this looks fine to me.

@jdemeyer
Copy link
Author

comment:7

Yes, this implements (1). After looking at the thread again, I'd say that (1) was the consensus.

@ppurka
Copy link
Member

ppurka commented Jan 11, 2013

comment:8

This looks good to me. I installed the spkg and the patch, and got no surprises. Tried out some small package like cliquer and it finished within 2 sec, cython took 22sec.

@ohanar: since you are the main author of the ccache ticket, I will wait for your input - if you have no objection, then set it to positive review.

@ohanar
Copy link
Member

ohanar commented Jan 11, 2013

comment:9

no objection

@ohanar
Copy link
Member

ohanar commented Jan 11, 2013

Reviewer: R. Andrew Ohana, Punarbasu Purkayastha

@jdemeyer
Copy link
Author

Merged: sage-5.6.rc0

@haraldschilly
Copy link
Member

comment:12

spkg is on the servers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants