-
-
Notifications
You must be signed in to change notification settings - Fork 535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set CCACHE_DIR #13938
Comments
comment:1
Attachment: 13938_ccache_default_dir.patch.gz |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Attachment: ccache-3.1.9.diff.gz Diff for the ccache spkg, for review only |
comment:6
This appears to implement (1) from the sage-devel discussion, but to me it seemed like (3) was more the consensus from that thread. If (1) is the consensus, then this looks fine to me. |
comment:7
Yes, this implements (1). After looking at the thread again, I'd say that (1) was the consensus. |
comment:8
This looks good to me. I installed the spkg and the patch, and got no surprises. Tried out some small package like cliquer and it finished within 2 sec, cython took 22sec. @ohanar: since you are the main author of the ccache ticket, I will wait for your input - if you have no objection, then set it to positive review. |
comment:9
no objection |
Reviewer: R. Andrew Ohana, Punarbasu Purkayastha |
Merged: sage-5.6.rc0 |
comment:12
spkg is on the servers! |
This is a follow-up to #13032. After consulting sage-devel, it seems like a bad idea to set
CCACHE_DIR
unconditionally, so let's not do this.Blocker because #13032 is a regression for people using a system-wide ccache installation.
optional spkg: http://boxen.math.washington.edu/home/jdemeyer/spkg/ccache-3.1.9.spkg
apply: attachment: 13938_ccache_default_dir.patch to the
SAGE_ROOT
repository.CC: @ppurka
Component: build
Author: Jeroen Demeyer
Reviewer: R. Andrew Ohana, Punarbasu Purkayastha
Merged: sage-5.6.rc0
Issue created by migration from https://trac.sagemath.org/ticket/13938
The text was updated successfully, but these errors were encountered: