Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error in preparsing generators, QuadraticField #1135

Closed
ncalexan mannequin opened this issue Nov 9, 2007 · 7 comments
Closed

Error in preparsing generators, QuadraticField #1135

ncalexan mannequin opened this issue Nov 9, 2007 · 7 comments
Assignees
@ncalexan
Labels
c: number fields p: major / 3 t: bug
Milestone
sage-4.6

Comments

@ncalexan
Copy link
Mannequin

ncalexan mannequin commented Nov 9, 2007 

sage: K.<a> = QuadraticField(-55, 'a')
---------------------------------------------------------------------------
<type 'exceptions.TypeError'>             Traceback (most recent call last)

/Users/ncalexan/emacs/<ipython console> in <module>()

<type 'exceptions.TypeError'>: QuadraticField() got multiple values for keyword argument 'names'

Component: number fields

Keywords: preparse generators QuadraticField

Author: Luis Felipe Tabera Alonso

Reviewer: Nick Alexander

Merged: sage-4.6.alpha2

Issue created by migration from https://trac.sagemath.org/ticket/1135
@ncalexan ncalexan mannequin added this to the sage-2.11 milestone Nov 9, 2007
@ncalexan ncalexan mannequin added c: interfaces labels Nov 9, 2007
@ncalexan ncalexan mannequin self-assigned this Nov 9, 2007
@sagetrac-mabshoff sagetrac-mabshoff mannequin modified the milestones: sage-2.11, sage-2.9.1 Dec 18, 2007
@loefflerd
Copy link
Mannequin

loefflerd mannequin commented Apr 16, 2010

comment:2

This clearly belongs in "number fields" ("interfaces" is for Sage interfaces to other software, not for user-interface issues).

@loefflerd loefflerd mannequin added c: number fields and removed c: interfaces labels Apr 16, 2010
@lftabera
Copy link
Contributor

Attachment: trac-1135.patch.gz

@lftabera
Copy link
Contributor

comment:3

This is a small error that is embarrasingly old. This patch solves the problem. You can use a generator name and the preparser in all combinations.

  • I have added a default name for the generator 'a' to be consistent with NumberField.

  • I have documented the behaviour of Sage when QuadraticField and NumberField are given two generators but there is a conflict in their names. The generator name given by the preparser has precedence in this case.

@lftabera
Copy link
Contributor

Author: Luis Felipe Tabera Alonso

@ncalexan
Copy link
Mannequin Author

ncalexan mannequin commented Sep 17, 2010

comment:4

Looks fine to me and passes tests on sage.math. Positive review!

@ncalexan
Copy link
Mannequin Author

ncalexan mannequin commented Sep 17, 2010

Reviewer: Nick Alexander

@qed777
Copy link
Mannequin

qed777 mannequin commented Sep 28, 2010

Merged: sage-4.6.alpha2

@qed777 qed777 mannequin removed the s: positive review label Sep 28, 2010
@qed777 qed777 mannequin closed this as completed Sep 28, 2010
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ncalexan ncalexan

Labels
c: number fields p: major / 3 t: bug
Projects
None yet
Milestone
sage-4.6
Development

No branches or pull requests
1 participant
@lftabera