Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to Solidity v0.8.23 #756

Closed
2 tasks
PaulRBerg opened this issue Dec 19, 2023 · 0 comments · Fixed by #758
Closed
2 tasks

Upgrade to Solidity v0.8.23 #756

PaulRBerg opened this issue Dec 19, 2023 · 0 comments · Fixed by #758
Assignees
@PaulRBerg @andreivladbrg

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Dec 19, 2023 •
edited
Loading

Context

Some contracts compiled with v0.8.21 cannot be verified on Etherscan because of this bug related to viaIR, which was patched in Solidity v0.8.22:

Code Generator: Fix output from via-IR code generator being dependent on which files were discovered by import callback. In some cases, a different AST ID assignment would alter the order of functions in internal dispatch, resulting in superficially different but semantically equivalent bytecode.

I will write a detailed post on Twitter later.

Task

  • Bump Solidity to v0.8.23
  • Ship package and GitHub release v1.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PaulRBerg PaulRBerg

@andreivladbrg andreivladbrg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build: bump solc to 0.8.23 sablier-labs/lockup
2 participants
@PaulRBerg @andreivladbrg