Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emit a "CreateAmounts" struct instead of individual params in the create events #238

Closed
PaulRBerg opened this issue Jan 4, 2023 · 2 comments

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Jan 4, 2023

After implementing #207 and #208 , I have struggled to find a good order for the parameters of the create events. Even as they are today, I don't like it much.

Then, there is the perennial StackTooDeep issue that we need to be wary of.

Emitting a single CreateAmounts struct instead of netDepositAmount, protocolFeeAmount, and operatorFeeAmount`, would address both of the concerns above.

@andreivladbrg
Copy link
Member

Emitting a single CreateAmounts struct

Sounds good

@PaulRBerg
Copy link
Member Author

Thanks, @andreivladbrg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants