You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
After implementing #207 and #208 , I have struggled to find a good order for the parameters of the create events. Even as they are today, I don't like it much.
Then, there is the perennial StackTooDeep issue that we need to be wary of.
Emitting a single CreateAmounts struct instead of netDepositAmount, protocolFeeAmount, and operatorFeeAmount`, would address both of the concerns above.
The text was updated successfully, but these errors were encountered:
After implementing #207 and #208 , I have struggled to find a good order for the parameters of the create events. Even as they are today, I don't like it much.
Then, there is the perennial StackTooDeep issue that we need to be wary of.
Emitting a single
CreateAmounts
struct instead ofnetDepositAmount
, protocolFeeAmount, and
operatorFeeAmount`, would address both of the concerns above.The text was updated successfully, but these errors were encountered: