Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a comptroller #206

Closed
PaulRBerg opened this issue Dec 18, 2022 · 0 comments
Closed

Implement a comptroller #206

PaulRBerg opened this issue Dec 18, 2022 · 0 comments

Comments

@PaulRBerg
Copy link
Member

As discussed in sablier-labs/flow#1, we are preparing to expand the scope of the Sablier V2 protocol. We are considering implementing different "species" of streams in the future, a decision that challenges some of the assumptions we've had when we started working on this repository (v2-core).

Even if there will be different species of streams, it is likely that some configuration values will be common across all contracts (a great insight that @razgraf had during our latest in-person meeting). The initial values that are common today are the (i) protocol fees and (ii) the flash loan configuration, but there may be more in the future.

Therefore, we should implement a "comptroller" contract in charge of the protocol configuration, which would be connected to all Sablier V2 contracts by a storage value that can be edited by the contract owner. By making the value editable, we make it possible to extend the comptroller in a backward compatible manner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant