Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cover the "_cancel" and "_withdraw" internal functions of "SablierV2Pro" #117

Closed
PaulRBerg opened this issue Jul 26, 2022 · 0 comments
Closed

Cover the "_cancel" and "_withdraw" internal functions of "SablierV2Pro" #117

PaulRBerg opened this issue Jul 26, 2022 · 0 comments
Assignees
@andreivladbrg

Comments

@PaulRBerg
Copy link
Member

PaulRBerg commented Jul 26, 2022 •
edited
Loading

Our currents tests don't currently cover the _cancel and _withdraw functions in SablierV2Pro:

https://github.com/sablierhq/v2-core/blob/c04f0ffb71678e1c82a5cb6515fa54d68dc9e994/src/SablierV2Pro.sol#L381-L392

https://github.com/sablierhq/v2-core/blob/c04f0ffb71678e1c82a5cb6515fa54d68dc9e994/src/SablierV2Pro.sol#L483-L497
@PaulRBerg PaulRBerg changed the title Cover "cancelInternal" and "withdrawInternal" functions of "SablierV2Pro" Cover the "cancelInternal" and "withdrawInternal" functions of "SablierV2Pro" Jul 26, 2022
@PaulRBerg PaulRBerg changed the title Cover the "cancelInternal" and "withdrawInternal" functions of "SablierV2Pro" Cover the "_cancel" and "_withdraw" internal functions of "SablierV2Pro" Aug 11, 2022
@PaulRBerg PaulRBerg mentioned this issue Jan 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andreivladbrg andreivladbrg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@PaulRBerg @andreivladbrg