Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loadStrategy() option #24

Open
wants to merge 1 commit into
base: 3.x
Choose a base branch
from
Open

Add loadStrategy() option #24

wants to merge 1 commit into from

Conversation

wout-o
Copy link

@wout-o wout-o commented Sep 9, 2024

First of all, thank you for creating and maintaining this package!

In my use case, I found that the "idle" load strategy works more reliably than the default "visible" strategy, especially when handling modals on complex pages.

This PR introduces a loadStrategy() option, allowing users to customize the load strategy to suit their needs, rather than relying on the hardcoded default.

To ensure backward compatibility, the default strategy remains "visible", so no breaking changes are introduced.

@wout-o
Copy link
Author

wout-o commented Nov 6, 2024

@saade Could you please take a look at this?

@denizaygundev
Copy link

denizaygundev commented Feb 16, 2025

@wout-o would be great to get this merged, it solves this issue for me: #25

Edit - for anyone needing this urgently, you can publish the package's views with php artisan vendor:publish then choose Saade\FilamentAutograph\FilamentAutographServiceProvider, and update to ax-load="idle"`

@saade
Copy link
Owner

saade commented Feb 16, 2025

Thanks guys, missed this PR, i'll look into this asap

@denizaygundev
Copy link

@saade thank you! Also not sure what's changed in the latest filament versions but something (somewhat related to this issue I think) is breaking the signaturePad from loading so I've locked to 3.2.136 for now, but something in 3.2.137 to 3.2.140 breaks your package: https://github.com/filamentphp/filament/releases

@saade
Copy link
Owner

saade commented Feb 18, 2025

@denizaygundev Async alpine got updated to V2. It was expected to some plugins to break, but there is a MutationObserver in place to migrate v1 to v2 syntax and help minimize the damage, its probably failing to do its job inside modals.

Read more here:
filamentphp/filament#15559

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants