Skip to content

Commit

Permalink
Add advisory to memoffset (#1721)
Browse files Browse the repository at this point in the history
* Add advisory to `memoffset`

* fix invalid category
  • Loading branch information
KisaragiEffective authored Jun 21, 2023
1 parent 29b04da commit 27aa255
Showing 1 changed file with 19 additions and 0 deletions.
19 changes: 19 additions & 0 deletions crates/memoffset/RUSTSEC-0000-0000.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
```toml
[advisory]
id = "RUSTSEC-0000-0000"
package = "memoffset"
date = "2023-06-21"
url = "https://github.com/Gilnaa/memoffset/issues/24"
informational = "unsound"
categories = ["memory-corruption"]
keywords = ["memoffset", "offset"]
[affected]
functions = { "memoffset::offset_of" = ["< 0.6.2"] }
[versions]
patched = [">= 0.6.2"]
```

# memoffset allows reading uninitialized memory
memoffset allows attempt of reading data from address `0` with arbitrary type. This behavior is an undefined behavior because address `0` to `std::mem::size_of<T>` may not have valid bit-pattern with `T`. Old implementation dereferences uninitialized memory obtained from `std::mem::align_of`. Older implementation prior to it allows using uninitialized data obtained from `std::mem::uninitialized` with arbitrary type then compute offset by taking the address of field-projection. This may also result in an undefined behavior for "father" that includes (directly or transitively) type that [does not allow to be uninitialized](https://doc.rust-lang.org/nightly/reference/behavior-considered-undefined.html).

This flaw was corrected by using `std::ptr::addr_of` in <https://github.com/Gilnaa/memoffset/pull/50>.

0 comments on commit 27aa255

Please sign in to comment.