Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect HighDPI setting on Mac. #927

Closed
mooman219 opened this issue Jun 15, 2019 · 3 comments
Closed

Incorrect HighDPI setting on Mac. #927

mooman219 opened this issue Jun 15, 2019 · 3 comments
Labels
B - bug Dang, that shouldn't have happened DS - macos

Comments

@mooman219
Copy link

Relevant Apple docs

It looks like setWantsBestResolutionOpenGLSurface is not being set to true on mac. This results in the program being provided a 1-pixel-per-point framebuffer regardless of the backing scale factor for the display the view occupies. This means that glViewport is implicitly called for you, and calling it yourself will almost certainly result in an incorrect famebuffer size. To match how DPI scaling works on other systems (Windows and Linux), setWantsBestResolutionOpenGLSurface should be set to true on Mac. This forces the view to perform the correct conversions between view units (points) and pixel units as needed.

This is probably a breaking change.

@goddessfreya
Copy link
Contributor

@goddessfreya goddessfreya transferred this issue from rust-windowing/glutin Jun 15, 2019
@goddessfreya goddessfreya added DS - macos B - bug Dang, that shouldn't have happened labels Jun 15, 2019
@goddessfreya
Copy link
Contributor

Related: #821

@madsmtm
Copy link
Member

madsmtm commented Jan 3, 2022

Closing, I believe @goddessfreya answered this, and #1073 even added a switch for changing this behaviour.

Feel free to reopen if you're still having problems with this, @mooman219.

@madsmtm madsmtm closed this as completed Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B - bug Dang, that shouldn't have happened DS - macos
Development

No branches or pull requests

3 participants