You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In a similar vein to rust-num/num-traits#177 (fixed by rust-num/num-traits#185), it would be great if support for i128 could be made optional using a cargo feature. The new i128 feature would enable num-traits/i128 and num-integer/i128, and any code in num-rational using the i128 type would need to be conditionally compiled. Basically, add the same kind of i128 feature detection that num-traits and num-integer use, where it turns on the feature if either the cargo feature is enabled, or the probe detects i128 support.
The text was updated successfully, but these errors were encountered:
The current num-rational uses features = ["i128"] unconditionally for those dependencies, which should bypass probing if you're using at least num-traits 0.2.13 and num-integer 0.1.44. Do you find otherwise?
Ah, never mind! I was specifying versions for num-rational and num-traits, but had not updated num-integer in my Cargo.lock. On the latest versions of all of those it seems to work. Sorry for the noise.
In a similar vein to rust-num/num-traits#177 (fixed by rust-num/num-traits#185), it would be great if support for i128 could be made optional using a cargo feature. The new
i128
feature would enablenum-traits/i128
andnum-integer/i128
, and any code innum-rational
using thei128
type would need to be conditionally compiled. Basically, add the same kind ofi128
feature detection thatnum-traits
andnum-integer
use, where it turns on the feature if either the cargo feature is enabled, or the probe detects i128 support.The text was updated successfully, but these errors were encountered: