Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make i128 support optional #95

Closed
dbeckwith opened this issue Mar 24, 2021 · 2 comments
Closed

Make i128 support optional #95

dbeckwith opened this issue Mar 24, 2021 · 2 comments

Comments

@dbeckwith
Copy link

In a similar vein to rust-num/num-traits#177 (fixed by rust-num/num-traits#185), it would be great if support for i128 could be made optional using a cargo feature. The new i128 feature would enable num-traits/i128 and num-integer/i128, and any code in num-rational using the i128 type would need to be conditionally compiled. Basically, add the same kind of i128 feature detection that num-traits and num-integer use, where it turns on the feature if either the cargo feature is enabled, or the probe detects i128 support.

@cuviper
Copy link
Member

cuviper commented Mar 25, 2021

The current num-rational uses features = ["i128"] unconditionally for those dependencies, which should bypass probing if you're using at least num-traits 0.2.13 and num-integer 0.1.44. Do you find otherwise?

@dbeckwith
Copy link
Author

Ah, never mind! I was specifying versions for num-rational and num-traits, but had not updated num-integer in my Cargo.lock. On the latest versions of all of those it seems to work. Sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants