Small maintainance improvements in cargo and rustc #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xFrednet
force-pushed
the
000-maintenance-magic
branch
from
23d83b7 to
a7e4ea1
Compare
Niki4tap
approved these changes
Apr 6, 2023
There was a problem hiding this comment.
Looks great to me!
bors r+
side note: I'm a bit more busier than I've expected, but I should still be able to review your PRs. I think I have a local branch that covers some tasks from #81, but it needs a bit of a cleanup, I'll try to PR it as soon as I can.
|
Build succeeded:
|
No problem at all, thank you for the review! The same thing happened to me, my current courses are taking a bit more time than expected. But I'm motivated again, which is a good baseline I'd say :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does some cleanup around the rustc driver and cargo. The commits should structure the changes pretty well.
I took a break after my exam week. It has been pretty good, but now I want and need to get back into marker. I hope that this PR is just the start of it :)
r? @Niki4tap Would you still have time to review my PRs? 🙃