Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update #[inline] guidance #57

Open
ChrisDenton opened this issue Jul 7, 2023 · 0 comments
Open

Update #[inline] guidance #57

ChrisDenton opened this issue Jul 7, 2023 · 0 comments

Comments

@ChrisDenton
Copy link
Member

Our current guidance on using #[inline] should mention profiling as our guiding principle even in places where we currently think the attribute "shouldn't" be needed (and maybe we want to revisit those "shouldn't"s). I think it can be inferred from the docs that making changes to #[inline] can be a separate PR to other changes but we should make that more explicit.

See also rust-lang/rust#109546. cc @saethlin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ChrisDenton