Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixup ci errors. Clippy on beta channel is broken #1977

Closed
wants to merge 1 commit into from
Closed

Fixup ci errors. Clippy on beta channel is broken #1977

wants to merge 1 commit into from

Conversation

baloo
Copy link

@baloo baloo commented Aug 28, 2019

Clippy on beta is broken and reports like:

error: cannot find macro `pre_install_msg_template!` in this scope
  --> src/cli/self_update.rs:98:9
   |
98 |         pre_install_msg_template!(
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: cannot find macro `pre_install_msg_template!` in this scope
   --> src/cli/self_update.rs:109:9
    |
109 |         pre_install_msg_template!(
    |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: cannot find macro `pre_install_msg_template!` in this scope
   --> src/cli/self_update.rs:118:9
    |
118 |         pre_install_msg_template!(
    |         ^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused macro definition
  --> src/cli/self_update.rs:62:1
   |
62 | / macro_rules! pre_install_msg_template {
63 | |     ($platform_msg: expr) => {
64 | |         concat!(
65 | |             r"
...  |
93 | |     };
94 | | }
   | |_^
   |
   = note: `#[warn(unused_macros)]` on by default

This does not happens on neither stable nor nightly channel.

Clippy on beta is broken and reports like:
```
error: cannot find macro `pre_install_msg_template!` in this scope
  --> src/cli/self_update.rs:98:9
   |
98 |         pre_install_msg_template!(
   |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: cannot find macro `pre_install_msg_template!` in this scope
   --> src/cli/self_update.rs:109:9
    |
109 |         pre_install_msg_template!(
    |         ^^^^^^^^^^^^^^^^^^^^^^^^

error: cannot find macro `pre_install_msg_template!` in this scope
   --> src/cli/self_update.rs:118:9
    |
118 |         pre_install_msg_template!(
    |         ^^^^^^^^^^^^^^^^^^^^^^^^

warning: unused macro definition
  --> src/cli/self_update.rs:62:1
   |
62 | / macro_rules! pre_install_msg_template {
63 | |     ($platform_msg: expr) => {
64 | |         concat!(
65 | |             r"
...  |
93 | |     };
94 | | }
   | |_^
   |
   = note: `#[warn(unused_macros)]` on by default
```

This does not happens on neither stable nor nightly channel.

Signed-off-by: Arthur Gautier <baloo@gandi.net>
@kinnison
Copy link
Contributor

Hi,

We are very aware that beta's clippy is current broken. We deliberately left our clippy job on the beta channel to provide a warning mechanism for us to detect issues coming down the pipe in the next release. Indeed this caused us to report and track an issue in the compiler.

The fix hit nightly from rust-lang/rust#63717 and we're waiting on a beta backport for now.

Thanks again for your contribution, but we won't be taking this at this time.

@kinnison kinnison closed this Aug 29, 2019
@baloo baloo deleted the baloo/fixup-ci branch August 29, 2019 16:58
@baloo
Copy link
Author

baloo commented Aug 29, 2019

makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants